Skip to content

Install: use setuptools bdist_wheel; CI: call pytest as module #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ipanfilo merged 2 commits into from
May 30, 2026
+11 −4
Merged

Install: use setuptools bdist_wheel; CI: call pytest as module #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb53a2
Install: use setuptools bdist_wheel; CI: call pytest as module
ipanfilo May 29, 2026
39c6d4e
Address review comments
ipanfilo May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ci/_utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ start_message() {
fi
_rocm_path=`$REALPATH "$_rocm_path"`
test -d "$_rocm_path" && echo "ROCm: $_rocm_path" || echo "ROCm path not found"
python --version
python3 --version
}

configure_omp_threads() {
Expand Down Expand Up @@ -266,6 +266,7 @@ pytest_run() {
check_test_filter $_test_name_tag || return
_start_ts=`date +%s`
echo "Run [$_test_variant_tag] $@ at `time_elapsed $TEST_START_TS`"
pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@" || test_run_error "[$_test_variant_tag] $1"
python3 -m pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@"
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener May 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 237 above, we run python, not python3, perhaps we could also use python here? (perhaps it would also make sense to additionally run which python above to log which actual python binary is used)

Suggested change
python3 -m pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@"
python -m pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@"

Copy link
Copy Markdown
Collaborator Author

@ipanfilo ipanfilo May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed line 237 to python3 because it is recommended way to run it.

test $? -eq 0 || test_run_error "[$_test_variant_tag] $1"
echo "Done [$_test_variant_tag] $1 in `time_elapsed $_start_ts`"
}
5 changes: 4 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@

import setuptools
from setuptools.command.egg_info import egg_info
from wheel.bdist_wheel import bdist_wheel
try:
from setuptools.command.bdist_wheel import bdist_wheel
except ImportError:
from wheel.bdist_wheel import bdist_wheel

from build_tools.build_ext import CMakeExtension, get_build_ext
from build_tools.te_version import te_version
Expand Down
5 changes: 4 additions & 1 deletion transformer_engine/pytorch/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
import platform
import urllib
import setuptools
from wheel.bdist_wheel import bdist_wheel as _bdist_wheel
try:
from setuptools.command.bdist_wheel import bdist_wheel as _bdist_wheel
except ImportError:
from wheel.bdist_wheel import bdist_wheel as _bdist_wheel
from packaging.version import parse

try:
Expand Down
Loading