Skip to content

Install: use setuptools bdist_wheel; CI: call pytest as module#601

Open
ipanfilo wants to merge 2 commits into
devfrom
ipanfilo/python_314
Open

Install: use setuptools bdist_wheel; CI: call pytest as module#601
ipanfilo wants to merge 2 commits into
devfrom
ipanfilo/python_314

Conversation

@ipanfilo
Copy link
Copy Markdown
Collaborator

Description

Compatibility changes for python 3.14 images

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Use setuptools bdist_wheel since wheel one is deprecated
  • Call python -m pytest instead of pytest in CI to fix incorrect python running on images with multiple pythons

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ipanfilo ipanfilo added the ci-level 1 CI test level 1 label May 29, 2026
@ipanfilo ipanfilo requested a review from matthiasdiener May 29, 2026 05:26
@ipanfilo ipanfilo marked this pull request as ready for review May 29, 2026 05:26
@ipanfilo ipanfilo requested a review from VeeraRajasekhar May 29, 2026 05:26
Comment thread ci/_utils.sh
_start_ts=`date +%s`
echo "Run [$_test_variant_tag] $@ at `time_elapsed $TEST_START_TS`"
pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@" || test_run_error "[$_test_variant_tag] $1"
python3 -m pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@"
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 237 above, we run python, not python3, perhaps we could also use python here? (perhaps it would also make sense to additionally run which python above to log which actual python binary is used)

Suggested change
python3 -m pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@"
python -m pytest -v -rfEs `get_pytest_junitxml $_test_name_tag` $TEST_PYTEST_ARGS "$TEST_DIR/$@"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed line 237 to python3 because it is recommended way to run it.

@ipanfilo ipanfilo requested a review from matthiasdiener May 30, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 1 CI test level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants