Skip to content

fix: Prevent playback on invalid targets #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-y-z wants to merge 3 commits into from
Closed

fix: Prevent playback on invalid targets #596

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e08414c
fix: Prevent playback on invalid targets
alex-y-z Oct 3, 2025
8577743
fix: Correct localization warning condition
alex-y-z Oct 5, 2025
d6d8ccf
Revert "fix: Correct localization warning condition"
alex-y-z Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/animations/src/Shared/AnimationSlotPlayer.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@
end)

topMaid:GiveTask(self._animationTarget
:ObserveBrio(function(target)

Check failure on line 299 in src/animations/src/Shared/AnimationSlotPlayer.lua

View workflow job for this annotation

GitHub Actions / luau-lsp

luau-lsp(TypeError) 

Expected this to be
	'((Instance?) -> boolean)?'
but got
	'({- Parent: 'a -}) -> boolean'
caused by:
  None of the union options are compatible. For example:
Expected this to be
	'(Instance?) -> boolean'
but got
	'({- Parent: 'a -}) -> boolean'
caused by:
  Argument #1 type is not compatible.
Expected this to be '{- Parent: 'a -}', but got 'Instance?'
return target ~= nil
return target ~= nil and target.Parent ~= nil
end)
:Subscribe(function(brio)
if brio:IsDead() then
Expand Down
Loading