fix: Prevent playback on invalid targets#596
Closed
alex-y-z wants to merge 3 commits into
Closed
Conversation
alex-y-z
force-pushed
the
users/alex-y-z/misc-fixes
branch
from
7400274 to
d6d8ccf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnimationSlotPlayercurrently attempts playback even as targets are being destructed. In cases where the animator has already been destroyed,HumanoidAnimatorUtilsneedlessly creates a new one on the client, which produces a warning.This checks if the animation target has a valid parent before attempting playback.