Skip to content

Inline colored point cloud subtrees into register_cad_part#527

Open
davetcoleman wants to merge 1 commit intomainfrom
dave/inline-colored-pointcloud-subtrees
Open

Inline colored point cloud subtrees into register_cad_part#527
davetcoleman wants to merge 1 commit intomainfrom
dave/inline-colored-pointcloud-subtrees

Conversation

@davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Mar 5, 2026

Summary

  • Inline Load Mesh as Green Point Cloud and Load Mesh as Red Point Cloud subtrees directly into register_cad_part and register_cad_part_subtree objectives - these subtrees were not reusable and only added complexity to understand what this toy problem does.
  • Delete the now-unused subtree objective files
  • Add reference_frame and BreakpointSubscriber to register_cad_part

Test plan

  • Run Register CAD Part objective and verify point cloud loading works
  • Verify red and green point clouds display correctly

🤖 Generated with Claude Code

@davetcoleman davetcoleman requested a review from nbbrooks March 5, 2026 00:53
@davetcoleman davetcoleman marked this pull request as ready for review March 5, 2026 00:53
@JWhitleyWork JWhitleyWork force-pushed the dave/inline-colored-pointcloud-subtrees branch from 88b3565 to 2bc903d Compare March 5, 2026 18:10
@JWhitleyWork
Copy link
Member

Rebased to pick up CI fix.

@davetcoleman davetcoleman force-pushed the dave/inline-colored-pointcloud-subtrees branch from 2bc903d to 139443d Compare March 6, 2026 18:59
Remove Load Mesh as Green/Red Point Cloud subtree objectives and inline
their behavior directly into register_cad_part and register_cad_part_subtree.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@davetcoleman davetcoleman force-pushed the dave/inline-colored-pointcloud-subtrees branch from 139443d to 6d646d0 Compare March 6, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants