Skip to content

Mark Assassin's Creed III as "testing" (Uplay not working) #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plata merged 3 commits into from
Jun 8, 2019
Merged

Mark Assassin's Creed III as "testing" (Uplay not working) #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bd63a1
Doesn't work, testing is required
Jun 6, 2019
d417c1d
json aligned
Jun 8, 2019
8c264ff
bcs reasons..
Jun 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Applications/Games/Assassin's Creed III/Steam/script.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
"compatibleOperatingSystems" : [
"LINUX"
],
"testingOperatingSystems" : [],
"free" : false,
"requiresPatch" : false
"testingOperatingSystems" : [
"LINUX"
],
"free" : false,
"requiresPatch" : false
}
2 changes: 1 addition & 1 deletion Engines/Wine/Verbs/FAudio/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ include("utils.functions.filesystem.files");
* @returns {Wine} Wine object
*/
Wine.prototype.faudio = function (faudioVersion) {
if(typeof faudioVersion !== 'string')
if (typeof faudioVersion !== 'string')
Copy link
Contributor Author

@Kreyren Kreyren Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blame @ImperatorS79 !

Copy link
Collaborator

@plata plata Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to blame people who try to help you!

Copy link
Contributor Author

@Kreyren Kreyren Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata You blame ppl in linux if they do something wrong so that they know about it.. it's the way we QA each other and i encourage you to do the same.

Copy link
Member

@qparis qparis Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kreyren There is a big difference between destructive / personal attack and code review / constructive remarks and quality assurance. Please beware of it.

faudioVersion = "19.05";

var setupFile = new Resource()
Expand Down