-
Notifications
You must be signed in to change notification settings - Fork 45
Mark Assassin's Creed III as "testing" (Uplay not working) #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failing to pass Travis-CI suspect false trigger. 🤔 |
|
Any idea why it does not work in Steam but in Uplay? For me this doesn't make sense. |
your provided example for uplay script has this sytax err i think it was sourced from there. |
The Steam script does not work because of a syntax error in the Uplay script? |
Travis ignores syntax error in uplay script which is same syntax err as in #989 -> suspecting it beeing relevant and definitions sourced from the docs. |
|
Please check Travis. There's an issue with json-align. See the docs. Note: this requirement is described in the pull request how-to in the README. |
| */ | ||
| Wine.prototype.faudio = function (faudioVersion) { | ||
| if(typeof faudioVersion !== 'string') | ||
| if (typeof faudioVersion !== 'string') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blame @ImperatorS79 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason to blame people who try to help you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plata You blame ppl in linux if they do something wrong so that they know about it.. it's the way we QA each other and i encourage you to do the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kreyren There is a big difference between destructive / personal attack and code review / constructive remarks and quality assurance. Please beware of it.
As refferenced on #967 (comment) this script is not working -> push in testing