Skip to content

Conversation

@Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Jun 6, 2019

As refferenced on #967 (comment) this script is not working -> push in testing

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 6, 2019

Failing to pass Travis-CI suspect false trigger. 🤔

@plata
Copy link
Collaborator

plata commented Jun 6, 2019

Any idea why it does not work in Steam but in Uplay? For me this doesn't make sense.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 6, 2019

Any idea why it does not work in Steam but in Uplay? For me this doesn't make sense.

your provided example for uplay script has this sytax err i think it was sourced from there.

@plata
Copy link
Collaborator

plata commented Jun 6, 2019

your provided example for uplay script has this sytax err i think it was sourced from there.

The Steam script does not work because of a syntax error in the Uplay script?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 6, 2019

your provided example for uplay script has this sytax err i think it was sourced from there.

The Steam script does not work because of a syntax error in the Uplay script?

Travis ignores syntax error in uplay script which is same syntax err as in #989 -> suspecting it beeing relevant and definitions sourced from the docs.

@plata
Copy link
Collaborator

plata commented Jun 7, 2019

Please check Travis. There's an issue with json-align. See the docs. Note: this requirement is described in the pull request how-to in the README.

@plata plata changed the title Push Assassin's Creed III in testing (Doesn't work) Mark Assassin's Creed III as "testing" (Uplay not working) Jun 7, 2019
*/
Wine.prototype.faudio = function (faudioVersion) {
if(typeof faudioVersion !== 'string')
if (typeof faudioVersion !== 'string')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blame @ImperatorS79 !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to blame people who try to help you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata You blame ppl in linux if they do something wrong so that they know about it.. it's the way we QA each other and i encourage you to do the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kreyren There is a big difference between destructive / personal attack and code review / constructive remarks and quality assurance. Please beware of it.

@plata plata merged commit 3e31b10 into PhoenicisOrg:master Jun 8, 2019
@PhoenicisOrg PhoenicisOrg locked as too heated and limited conversation to collaborators Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants