Skip to content

Fixed for #1474 Updating CalcDefense for it to consider items like Starkonja's, Rise of the Pheonix when is use with a different low life modifies items like Coward Legacy. #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NamNgHH wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fixed for #1474 Updating CalcDefense for it to consider items like Starkonja's, Rise of the Pheonix when is use with a different low life modifies items like Coward Legacy. #1704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45398e6
Update CalcDefence.lua
NamNgHH Dec 29, 2025
635ec78
Merge branch 'test' into test2
NamNgHH Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Modules/CalcDefence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,11 @@ function calcs.defence(env, actor)

local condList = modDB.conditions

-- Pre-calculate Life/Mana/Spirit and reservations to set conditions (like LowLife) before defences are calculated
-- This ensures modifiers that depend on conditions (e.g., "when on Low Life") work correctly
calcs.doActorLifeManaSpirit(actor, true)
calcs.doActorLifeManaSpiritReservation(actor)

-- Action Speed
output.ActionSpeedMod = calcs.actionSpeedMod(actor)

Expand Down Expand Up @@ -1111,8 +1116,7 @@ function calcs.defence(env, actor)
end
-- Primary defences: Energy shield, evasion and armour
do
-- Pre-calculate Life/Mana/Spirit for mods such as Beidat's hand
calcs.doActorLifeManaSpirit(actor, true)
-- Life/Mana/Spirit already calculated above for conditions
local ward = 0
local energyShield = 0
local armour = 0
Expand Down