Skip to content

Conversation

@NamNgHH
Copy link

@NamNgHH NamNgHH commented Jan 3, 2026

Fixes # 1474.

Description of the problem being solved:

The issue was to fix the Coward's Legacy belt lowlife modifiers not working correctly. This was wrong since it worked correctly, verified by using the Pain Atunement note that 75% Lowlife is accounted correctly with Beidat's Hand. So the thing that doesn't work is the defense's calculation of items like Starkonja's Head or Rise of the Phoenix. So I solved the problem by changing calcs.defence functions.

Steps taken to verify a working solution:

  • Before the changes, the build is equipped with Starkonja's Head, Rise of Phoenix, and the evasion rating and fire resistance don't change when Beidat's Hand is taken, and having Coward's Legacy equipped.
  • Currently, if I take out Coward's Legacy, the lowlife effect of Starkonja's and Rise of the Phoenix doesn't affect my character
  • If I unallocate Beidat's Hand, the lowlife effect will also stop working since you are not a lowlife anymore.

Link to a build that showcases this PR:

https://pobb.in/R8tUNGCcbxCR

Before screenshot:

image image

After screenshot:

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant