Skip to content

605 logical routers should be attachable to vsys objects #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adambaumeister wants to merge 5 commits into
base: develop
Choose a base branch
from
+6 −0
Open

605 logical routers should be attachable to vsys objects #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90c1201
fix: Add Logical routers to vsys object #605
adambaumeister Jan 26, 2026
3a6288f
fix: Add logical-router to vsys impports #605
adambaumeister Jan 26, 2026
1012ed6
fix: Include supported version specification
adambaumeister Jan 27, 2026
ec2b3c5
fix: Change the logical router versioning to exclude when it's on <10.2
adambaumeister Jan 27, 2026
83c6193
chore: Fix black linting
adambaumeister Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions panos/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3479,6 +3479,7 @@ def set_vsys(
"vlan": "vlans",
"virtual-wire": "virtual_wires",
"virtual-router": "virtual_routers",
"logical-router": "logical_routers",
"interface": "interface",
}
for key, param_name in import_to_vsys_param.items():
Expand Down
5 changes: 5 additions & 0 deletions panos/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class Vsys(VersionedPanObject):
vlans (list): A list of strings of VLANs
virtual_wires (list): A list of strings of virtual wires
virtual_routers (list): A list of strings of virtual routers
logical_routers (list): (10.2+) A list of strings of logical routers
visible_vsys (list): A list of strings of the vsys visible
dns_proxy (str): DNS Proxy server
decrypt_forwarding (bool): Allow forwarding of decrypted content
Expand Down Expand Up @@ -188,6 +189,10 @@ def _setup(self):
path="import/network/virtual-router",
)
)
params.append(VersionedParamPath("logical_routers", exclude=True))
params[-1].add_profile(
"10.2.0", path="import/network/logical-router", vartype="member"
)
params.append(
VersionedParamPath(
"visible_vsys", vartype="member", path="import/visible-vsys"
Expand Down
Loading