605 logical routers should be attachable to vsys objects #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambaumeister
requested review from
alperenkose,
horiagunica and
jamesholland-uk
jamesholland-uk
requested review from
shinmog
and removed request for
jamesholland-uk
shinmog
requested changes
Jan 27, 2026
Collaborator
shinmog
left a comment
shinmog
left a comment
There was a problem hiding this comment.
It looks like logical routers were added in PAN-OS 10.2...?
If that's the case, then the code for this needs to reflect that. You can refer to this code to see how to add a param for something that only started existing in a particular version:
https://github.com/PaloAltoNetworks/pan-os-python/blob/develop/panos/network.py#L155-L165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables vsys handling for logical routers.