Adding the option to skip resolve on hangup#153
Open
armiiller wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new configuration option to the Live Call Routing (Twilio v3) integration to prevent automatically resolving alerts when a caller hangs up before being connected, and exposes that option in the integration UI.
Changes:
- Added
skip_resolve_on_hangupboolean option to the Twilio v3 integration model (with validation/default). - Updated hangup-handling logic to conditionally skip auto-resolving in some hangup scenarios.
- Added UI + i18n strings to configure and display the new option.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config/locales/en.yml | Adds label + hint text for the new option. |
| app/views/pager_tree/integrations/live_call_routing/twilio/v3/_show_options.html.erb | Displays the option status in the “show” options panel. |
| app/views/pager_tree/integrations/live_call_routing/twilio/v3/_form_options.html.erb | Adds a checkbox to configure the new option. |
| app/models/pager_tree/integrations/live_call_routing/twilio/v3.rb | Implements the option and updates hangup resolution behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
467
to
468
| adapter_alert.logs.create!(message: "Caller hungup before being put in a queue. Marking alert as resolved.") | ||
| adapter_alert.resolve!(self, force: true) |
Comment on lines
442
to
446
| if queue_result == "hangup" | ||
| self.adapter_alert = alerts.find_by(thirdparty_id: _thirdparty_id) | ||
| adapter_alert.logs.create!(message: "Caller hungup while waiting in queue.") | ||
| adapter_alert.resolve!(self, force: true) | ||
| adapter_alert.resolve!(self, force: true) unless option_skip_resolve_on_hangup | ||
| queue_destroy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.