fix: update Common-UI submodule reference and ensure CI build stability #67
Conversation
WalkthroughThe changes update the Common-UI subproject by advancing its commit hash, modify the CI build scripts in the package.json to ensure that the Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Build Process
participant Scripts as Scripts Directory
participant Env as Environment File
participant Angular as Angular CLI Build
CI->>Scripts: Run chmod & execute ci-prebuild.js
Scripts-->>CI: Setup environment variables (including new properties)
CI->>Env: Run "touch src/environments/environment.ts"
CI->>Angular: Execute Angular build command
Angular-->>CI: Build process completes
Assessment against linked issues
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
package.json
Outdated
| "build-dev": "node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng build --configuration=development --aot", | ||
| "build-prod": "node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng build --configuration=production --aot", | ||
| "build-ci": "chmod +x ./scripts/*.js && ./scripts/ci-prebuild.js && node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng build --configuration=ci --aot", | ||
| "build-ci": "chmod +x ./scripts/*.js && ./scripts/ci-prebuild.js && touch src/environments/environment.ts && node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng build --configuration=ci --aot", |
There was a problem hiding this comment.
Can we add this touch to other scripts too?
Prod and test.
There was a problem hiding this comment.
Sure, will add it!
Ensured
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
angular.json (2)
55-61: Production Configuration: Valid File Replacement Setup
The production configuration now includes a"fileReplacements"array that correctly maps"src/environments/environment.ts"to"src/environments/environment.prod.ts", ensuring production-specific settings are applied at build time. Please verify that all production dependencies and environment-specific variables are appropriately configured in"environment.prod.ts".
69-75: Development Configuration: Verify File Replacement Intent
In the development configuration,"src/environments/environment.ts"is replaced with"src/environments/environment.prod.ts". Typically, one might expect a development-specific environment file (like"environment.dev.ts") to be used. Please confirm if using the production environment file for development builds is intentional for your CI or testing strategy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
angular.json(1 hunks)package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
|
Updated angular.json by adding fileReplacements for production and development configurations. Modified build scripts to ensure environment.ts exists before execution and preventing missing file issues. |
2 participants
📋 Description
JIRA ID:
GitHub Issue: Fixes PSMRI/AMRIT#58
npm run build-cipasses locally and on GitHub Actions.These updates ensure that the latest changes in Common-UI are correctly integrated into the project without breaking the build process.
✅ Type of Change
ℹ️ Additional Information
How Changes Were Tested:
npm run build-cilocally to confirm the build process completes without errors.git submodule update --init --recursive.Screenshots:
Local Build Success:
Git Submodule Status:
Summary by CodeRabbit