(fix) : Updated action's versions and .gitiginore #70
Conversation
WalkthroughThis pull request updates and streamlines several GitHub Actions workflows. Versions for actions such as checkout, Java setup, Node.js setup, and artifact upload have been upgraded. In the build workflows, redundant npm install commands have been removed and build commands adjusted. Additionally, the package-prod workflow file has been deleted, and the Changes
Sequence Diagram(s)sequenceDiagram
participant PR as "Pull Request Event"
participant Runner as "CI Runner"
PR->>Runner: Trigger build workflow (build-on-pull-request.yml)
Runner->>Runner: Checkout code (v4) with full history
Runner->>Runner: Setup Java (v4)
Runner->>Runner: Setup Node (v4)
Runner->>Runner: Update submodules
Runner->>Runner: Execute npm install --force & build steps
Runner-->>PR: Build result
sequenceDiagram
participant Commit as "Push to Repo"
participant Runner as "CI Runner"
Commit->>Runner: Trigger packaging workflow (package.yml)
Runner->>Runner: Checkout code (v4) with submodule parameters
Runner->>Runner: Setup Java (v4)
Runner->>Runner: Setup Node (v4)
Runner->>Runner: Execute npm run build-ci
Runner->>Runner: Upload artifact (v4)
Runner-->>Commit: Packaging completed
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.github/workflows/build-on-pull-request.yml (2)
11-17: Checkout Step Updated with New ParametersThe checkout step now employs
actions/checkout@v4and correctly addssubmodules: truealong withfetch-depth: 0to perform a full clone.
Note: Please remove the trailing whitespace at the end of line 17.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 17-17: trailing spaces
(trailing-spaces)
24-29: JDK Setup Action UpdatedUsing
actions/setup-java@v4with the specified Java version and distribution is correct.
Note: Remove trailing spaces on line 29.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 29-29: trailing spaces
(trailing-spaces)
.github/workflows/package.yml (3)
18-23: Checkout Step Adjustments in Package WorkflowThe checkout action now uses
actions/checkout@v4withsubmodules: trueandfetch-depth: 0.
Action Required: Please remove the trailing spaces at the end of line 21 and line 22.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
24-29: Java Setup Step – Indentation Correction NeededThe Java setup step is updated to use
actions/setup-java@v4; however, thejava-version: '17'key on line 27 is over-indented. For consistency, adjust the indentation to the expected level. For example:- java-version: '17' + java-version: '17'🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 27-27: wrong indentation: expected 8 but found 10
(indentation)
43-45: Whitespace Cleanup Needed in WAR Creation StepThe "Create WAR file" step appears to have trailing whitespace on line 43 and an extraneous blank line with trailing spaces on line 45. Please remove these to maintain clean YAML formatting.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/build-on-pull-request.yml(1 hunks).github/workflows/package-prod.yml(0 hunks).github/workflows/package.yml(2 hunks).gitignore(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/package-prod.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/build-on-pull-request.yml
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 29-29: trailing spaces
(trailing-spaces)
.github/workflows/package.yml
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[warning] 27-27: wrong indentation: expected 8 but found 10
(indentation)
[error] 42-42: trailing spaces
(trailing-spaces)
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
🔇 Additional comments (7)
.gitignore (1)
45-46: New Environment CI File IgnoredThe addition of
src/environments/environment.ci.tscomplements the existing ignore entry forsrc/environments/environment.ts. This change properly prevents sensitive or environment-specific configuration files from being tracked..github/workflows/build-on-pull-request.yml (3)
19-23: Submodule Update Block Looks GoodThe update submodules step using
git submodule initandgit submodule update --recursiveis appropriately configured.
30-34: Node.js Setup Action ConfirmedThe Node.js setup step now uses
actions/setup-node@v4withnode-version: 18—this looks correct.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 34-34: trailing spaces
(trailing-spaces)
35-41: Build Step Commands RevisedThe build step is streamlined by removing redundant commands and now uses
npm run build-ci, which aligns with the new configuration.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 41-41: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/package.yml (3)
30-34: Node.js Setup Step Looks CorrectThe Node.js setup step is correctly updated to
actions/setup-node@v4with the appropriate node version.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 33-33: wrong indentation: expected 8 but found 10
(indentation)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
35-41: Build Step Commands VerifiedThe build step now uses
npm run build-ciafter installing required packages. There are no logical issues in this block.
46-51: Artifact Upload Step is CorrectThe artifact upload step uses
actions/upload-artifact@v4appropriately with the given artifact name and path.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 50-50: trailing spaces
(trailing-spaces)
2 participants
📋 Description
JIRA ID:
Updated action's versions to the latest versions.
Added environment.ci.ts in .gitignore file
Removed package-prod.yml file
✅ Type of Change
ℹ️ Additional Information
Updated action's versions to the latest versions.
Added environment.ci.ts in .gitignore file
Removed package-prod.yml file
Summary by CodeRabbit