Skip to content

fix(node-ui): align context graph label fallbacks#611

Merged
Jurij89 merged 2 commits into
mainfrom
codex/cgux-m1-s8-label-followup
May 24, 2026
Merged

fix(node-ui): align context graph label fallbacks#611
Jurij89 merged 2 commits into
mainfrom
codex/cgux-m1-s8-label-followup

Conversation

@Jurij89
Copy link
Copy Markdown
Contributor

@Jurij89 Jurij89 commented May 24, 2026

Summary

  • Treat useMemoryEntities' initial URI-derived label as non-authoritative so unnamed urn:* entities fall back to readable URI-tail labels instead of raw URNs.
  • Centralize memory label predicates in one shared list and reuse it across entity derivation and graph label configs.
  • Add regression coverage for generic URN fallback labels and graph predicate consistency, including dc/elements/1.1/title.

Related

Files changed

File What
packages/node-ui/src/ui/lib/memoryLabels.ts Adds the shared memory label predicate list.
packages/node-ui/src/ui/hooks/useMemoryEntities.ts Uses the shared predicates and falls through when the current label is only the default URI-derived value.
packages/node-ui/src/ui/views/project/helpers.ts Uses the shared predicates for layer graph labels.
packages/node-ui/src/ui/views/project/components.tsx Uses the shared predicates for entity detail and subgraph mini graph labels.
packages/node-ui/src/ui/views/MemoryLayerView.tsx Uses the shared predicates for standalone memory layer graph labels.
packages/node-ui/test/* Adds/updates focused coverage for the two follow-up issues.

Test plan

  • pnpm --filter @origintrail-official/dkg-node-ui exec vitest run test/use-memory-entities-labels.test.ts test/graph-label-predicates.test.ts test/ka-detail-label.test.ts test/ui-compat.test.ts
  • git diff --check
  • pnpm --filter @origintrail-official/dkg-node-ui run build
  • pnpm --filter @origintrail-official/dkg-node-ui run build:ui
  • Local PR reviewer round against pr-diff.patch: no actionable comments.

@Jurij89 Jurij89 marked this pull request as ready for review May 24, 2026 11:28
Comment thread packages/node-ui/src/ui/hooks/useMemoryEntities.ts Outdated
Comment thread packages/node-ui/test/graph-label-predicates.test.ts Outdated
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex review completed — no issues found.

@Jurij89 Jurij89 merged commit 6358a5d into main May 24, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant