feat(node-ui): add shared context graph empty states#612
Merged
Conversation
| gap: 16px; | ||
| } | ||
| .v10-vm-empty-state { | ||
| .v10-empty-state.v10-vm-empty-state { |
There was a problem hiding this comment.
🟡 Issue: This VM-specific override now has the same specificity as the shared .v10-empty-state / .v10-stat-strip rules that are declared later, so those later rules win for overlapping properties. In practice the Verified Memory hero falls back to the generic empty-state spacing/surface, and the new StatStrip container also loses the intended v10-vm-hero-stats sizing. Move the VM overrides below the shared primitive block or increase specificity (for example .v10-vm-hero .v10-empty-state.v10-vm-empty-state and .v10-stat-strip.v10-vm-hero-stats).
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmptyStateandStatStripprimitives for S9, with layer-aware tone support and reusable styling.listAssertions(cg, 'swm')returns data.Related
agent-docs/context-graph-implementation-plan.mdsection 7.3.G-BACKEND-M5population behavior for a later backend-gated change.Files changed
packages/node-ui/src/ui/views/project/primitives.tsxEmptyState,StatStrip, and layer tone helpers.packages/node-ui/src/ui/views/project/components.tsxpackages/node-ui/src/ui/components/ActivityFeed.tsxpackages/node-ui/src/ui/styles.csspackages/node-ui/test/context-graph-empty-stat-components.test.tspackages/node-ui/test/context-graph-contrast.test.tspackages/node-ui/test/vm-hero-banner.test.tsStatStrip.Test plan
pnpm --filter @origintrail-official/dkg-node-ui exec vitest run test/context-graph-empty-stat-components.test.ts test/vm-hero-banner.test.ts test/layer-graph-panel.test.ts test/context-graph-contrast.test.ts test/use-memory-entities-counts.test.ts test/ka-detail-label.test.ts test/project-view-navigation.test.ts test/ui-compat.test.tspnpm --filter @origintrail-official/dkg-node-ui run buildpnpm --filter @origintrail-official/dkg-node-ui run build:uigit diff --checkhttp://127.0.0.1:5178/ui/: Context Graph Overview showed the sharedStatStrip, empty activity used sharedEmptyState, and Shared Memory > Assertions showed the M5 interim empty state.pr-diff.patch: round 1 found two styling fidelity issues; round 2 returned{"comments":[]}.Note: the local dev node emitted repeated API 500 console errors during browser smoke due its local data/API state. The UI still booted and the PR-specific Context Graph states rendered; this is not caused by this UI-only change.