Skip to content

Fix Windows build: Use forward slashes in vcpkg paths #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix Windows build: Use forward slashes in vcpkg paths #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f29144
Initial plan
Copilot Feb 18, 2026
1f36e81
Fix Windows OpenBLAS linking by using forward slashes in paths
Copilot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/cibuildwheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:
C:\vcpkg\vcpkg.exe install openblas:x64-windows
CIBW_ENVIRONMENT_WINDOWS: |
EASYSBA_LAPACK_LIBS=openblas
EASYSBA_INCLUDE_DIRS=C:\\vcpkg\\installed\\x64-windows\\include
EASYSBA_LIBRARY_DIRS=C:\\vcpkg\\installed\\x64-windows\\lib
INCLUDE=C:\\vcpkg\\installed\\x64-windows\\include
LIB=C:\\vcpkg\\installed\\x64-windows\\lib
PATH=C:\\vcpkg\\installed\\x64-windows\\bin;{PATH}
EASYSBA_INCLUDE_DIRS=C:/vcpkg/installed/x64-windows/include
EASYSBA_LIBRARY_DIRS=C:/vcpkg/installed/x64-windows/lib
INCLUDE=C:/vcpkg/installed/x64-windows/include
LIB=C:/vcpkg/installed/x64-windows/lib
Comment on lines +53 to +54
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INCLUDE and LIB are being overwritten to only the vcpkg paths. This can unintentionally drop the MSVC/Windows SDK include+lib search paths depending on how the toolchain env is initialized, leading to brittle builds. Safer options are to (a) rely solely on EASYSBA_INCLUDE_DIRS/EASYSBA_LIBRARY_DIRS (setup.py already consumes these), or (b) append to the existing values (similar to PATH) instead of replacing them.

Suggested change
INCLUDE=C:/vcpkg/installed/x64-windows/include
LIB=C:/vcpkg/installed/x64-windows/lib
INCLUDE=C:/vcpkg/installed/x64-windows/include;{INCLUDE}
LIB=C:/vcpkg/installed/x64-windows/lib;{LIB}

Copilot uses AI. Check for mistakes.
PATH=C:/vcpkg/installed/x64-windows/bin;{PATH}
Comment thread
alexlib marked this conversation as resolved.
run: python -m cibuildwheel --output-dir wheelhouse

- name: Upload wheels
Expand Down
Loading