Skip to content

Fix Windows build: Use forward slashes in vcpkg paths#2

Closed
Copilot wants to merge 2 commits into
masterfrom
copilot/ensure-openblas-installed
Closed

Fix Windows build: Use forward slashes in vcpkg paths#2
Copilot wants to merge 2 commits into
masterfrom
copilot/ensure-openblas-installed

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 18, 2026

Windows builds failed with LNK1181: cannot open input file 'openblas.lib'. The linker couldn't find the library despite vcpkg installing it correctly to C:\vcpkg\installed\x64-windows\lib.

Root cause: Backslashes in CIBW_ENVIRONMENT_WINDOWS paths were being stripped during YAML processing, resulting in malformed paths like C:vcpkginstalledx64-windowslib passed to the compiler.

Changes

Changed all Windows path separators in .github/workflows/cibuildwheel.yml from backslashes to forward slashes:

CIBW_ENVIRONMENT_WINDOWS: |
  EASYSBA_LAPACK_LIBS=openblas
  EASYSBA_INCLUDE_DIRS=C:/vcpkg/installed/x64-windows/include
  EASYSBA_LIBRARY_DIRS=C:/vcpkg/installed/x64-windows/lib
  INCLUDE=C:/vcpkg/installed/x64-windows/include
  LIB=C:/vcpkg/installed/x64-windows/lib

Windows accepts both separators; forward slashes avoid escaping issues in YAML multiline strings.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr view --json number,state,title (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: alexlib <747110+alexlib@users.noreply.github.com>
@alexlib alexlib marked this pull request as ready for review February 18, 2026 21:56
Copilot AI review requested due to automatic review settings February 18, 2026 21:56
Copilot AI changed the title [WIP] Ensure OpenBLAS is installed for the correct platform Fix Windows build: Use forward slashes in vcpkg paths Feb 18, 2026
Copilot AI requested a review from alexlib February 18, 2026 21:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows cibuildwheel GitHub Actions workflow so OpenBLAS (installed via vcpkg) can be found reliably during wheel builds, addressing a Windows linker failure caused by path escaping/formatting.

Changes:

  • Switch CIBW_ENVIRONMENT_WINDOWS vcpkg paths from backslashes to forward slashes.
  • Keep the OpenBLAS/vcpkg environment variables aligned with the x64-windows vcpkg install location.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +53 to +54
INCLUDE=C:/vcpkg/installed/x64-windows/include
LIB=C:/vcpkg/installed/x64-windows/lib
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INCLUDE and LIB are being overwritten to only the vcpkg paths. This can unintentionally drop the MSVC/Windows SDK include+lib search paths depending on how the toolchain env is initialized, leading to brittle builds. Safer options are to (a) rely solely on EASYSBA_INCLUDE_DIRS/EASYSBA_LIBRARY_DIRS (setup.py already consumes these), or (b) append to the existing values (similar to PATH) instead of replacing them.

Suggested change
INCLUDE=C:/vcpkg/installed/x64-windows/include
LIB=C:/vcpkg/installed/x64-windows/lib
INCLUDE=C:/vcpkg/installed/x64-windows/include;{INCLUDE}
LIB=C:/vcpkg/installed/x64-windows/lib;{LIB}

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/cibuildwheel.yml
@alexlib alexlib closed this Feb 18, 2026
@alexlib alexlib deleted the copilot/ensure-openblas-installed branch February 18, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants