code cleanup: calibration details binning as int, not double #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2025
Merged
agalasso
force-pushed
the
andy/rename-MaxBinning-to-MaxHwBinning
branch
from
bf8cf62 to
b75d67f
Compare
agalasso
force-pushed
the
andy/calibration-details-origBinning-int
branch
from
9cb859b to
1fcf6b6
Compare
bwdev01
approved these changes
Dec 23, 2025
agalasso
force-pushed
the
andy/rename-MaxBinning-to-MaxHwBinning
branch
from
b75d67f to
abe2ce9
Compare
agalasso
force-pushed
the
andy/calibration-details-origBinning-int
branch
from
1fcf6b6 to
9f24e03
Compare
agalasso
force-pushed
the
andy/rename-MaxBinning-to-MaxHwBinning
branch
from
abe2ce9 to
c2bd2ce
Compare
Base automatically changed from
andy/rename-MaxBinning-to-MaxHwBinning
to
master
December 31, 2025 22:07
The binning value can be stored as an int, not a double. This is backwards compatible with stored calibration values as the stored values can be read back as integer values even though they were written out as doubles.
agalasso
force-pushed
the
andy/calibration-details-origBinning-int
branch
from
9f24e03 to
def37a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code cleanup: calibration details binning as int, not double
The binning value can be stored as an int, not a double.
This is backwards compatible with stored calibration values
as the stored values can be read back as integer values
even though they were written out as doubles.