-
Notifications
You must be signed in to change notification settings - Fork 128
GuideCamera::Capture CaptureParams argument #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5220458 to
f2b0863
Compare
4b75980 to
47b1933
Compare
|
I'm missing something here. What is the benefit of pushing all these additional properties - gain, binning, bpp, etc - into the Capture() interface. Those things are already known to the underlying function because they are just properties of the camera. The new struct just looks to me like it has a bunch of tramp properties that, as a caller of Capture, I don't need to know about. |
|
This change accomplishes two things:
|
bwdev01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
47b1933 to
915feae
Compare
f2b0863 to
5f98640
Compare
915feae to
501c4fd
Compare
5f98640 to
6c1e074
Compare
Update GuideCamera::Capture method replacing individual capture parameter arguments with a struct wrapping all the capture parameters. This will make it easier to transform the arguments for software binning. No functional changes in this PR - just the arguments structure refactor.
501c4fd to
c4c2f06
Compare
GuideCamera::Capture CaptureParams argument
Update GuideCamera::Capture method replacing individual capture parameter arguments
with a struct wrapping all the capture parameters.
This will make it easier to transform the arguments for software binning #738.
No functional changes in this PR - just the arguments structure refactor.