Skip to content

Require enum-compat instead of enum34 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterHamilton merged 1 commit into from
Aug 28, 2019
Merged

Require enum-compat instead of enum34 #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cryptography>=1.4
enum34
enum-compat
requests
six>=1.11.0
sqlalchemy>=1.0
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
},
install_requires=[
"cryptography",
"enum34",
"enum-compat",
Copy link

@apevec apevec Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jstasiak/enum-compat/blob/master/README.rst suggests to use
enum34; python_version < '3.4'
directly.
With enum-compat, we get autogenerated RPM dep in Fedora Requires: python3.9dist(enum-compat) which does not exist.

Copy link
Contributor Author

@ctil ctil Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like it should be changed back to enum34; python_version < '3.4'. Looks like the README in enum-compat was updated a couple months after this was merged to say it's no longer needed.

"requests",
"six",
"sqlalchemy"
Expand Down