Require enum-compat instead of enum34 #579
Conversation
The enum34 package is not compatible with python 3.4+. By requiring enum-compat instead, this requirement will be a noop when installing the dependencies from a python 3.4+ environment. Closes: #450
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
======================================
Coverage 96% 96%
======================================
Files 75 75
Lines 15582 15582
======================================
Hits 14959 14959
Misses 623 623Continue to review full report at Codecov.
|
|
Hi @ctil, thanks for posting this. Should've taken care of this months ago. |
|
@PeterHamilton No problem. Thanks for the quick merge! |
| install_requires=[ | ||
| "cryptography", | ||
| "enum34", | ||
| "enum-compat", |
There was a problem hiding this comment.
https://github.com/jstasiak/enum-compat/blob/master/README.rst suggests to use
enum34; python_version < '3.4'
directly.
With enum-compat, we get autogenerated RPM dep in Fedora Requires: python3.9dist(enum-compat) which does not exist.
There was a problem hiding this comment.
Ah, looks like it should be changed back to enum34; python_version < '3.4'. Looks like the README in enum-compat was updated a couple months after this was merged to say it's no longer needed.
4 participants
The enum34 package is not compatible with python 3.4+. By
requiring enum-compat instead, this requirement will be a
noop when installing the dependencies from a python 3.4+ environment.
Closes: #450