Skip to content

Resolve serialization error during check for changes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MJRichardson merged 2 commits into from
Jun 17, 2025
Merged

Resolve serialization error during check for changes #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79a93b9
resolving error deserialising check for changes response
MJRichardson Jun 17, 2025
8a7a3b0
updated README to use setProviderAndWait
MJRichardson Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public class Main {

public static void main(String[] args) {
var openFeature = OpenFeatureAPI.getInstance();
openFeature.setProvider(new OctopusProvider(new OctopusConfiguration("Your Octopus client identifier")));
openFeature.setProviderAndWait(new OctopusProvider(new OctopusConfiguration("Your Octopus client identifier")));
var openFeatureClient = openFeature.getClient();

var darkModeIsEnabled = openFeatureClient.getBooleanValue("dark-mode", false);
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>com.octopus.openfeature</groupId>
<artifactId>octopus-openfeature-provider</artifactId>
<version>0.1.0</version>
<version>0.2.0</version>
<packaging>jar</packaging>

<name>Octopus Deploy OpenFeature Provider</name>
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/octopus/openfeature/provider/OctopusClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ Boolean haveFeatureTogglesChanged(byte[] contentHash)
if (contentHash.length == 0) { return true; }
URI checkURI = getCheckURI();
HttpClient client = HttpClient.newHttpClient();
// TODO: check client is v3
HttpRequest request = HttpRequest.newBuilder()
HttpRequest request = HttpRequest.newBuilder()
.GET()
.uri(checkURI)
.header("Authorization", String.format("Bearer %s", config.getClientIdentifier()))
Expand All @@ -50,7 +49,6 @@ FeatureToggles getFeatureToggleEvaluationManifest()
{
URI manifestURI = getManifestURI();
HttpClient client = HttpClient.newHttpClient();
// TODO: check client is v3
HttpRequest request = HttpRequest.newBuilder()
.GET()
.uri(manifestURI)
Expand Down Expand Up @@ -97,6 +95,6 @@ private Boolean isSuccessStatusCode(int statusCode) {

// This class needs to be static to allow deserialization
private static class FeatureToggleCheckResponse {
byte[] contentHash;
public byte[] contentHash;
}
}