Skip to content

Conversation

@MJRichardson
Copy link
Contributor

Closes #1

@MJRichardson MJRichardson self-assigned this Jun 17, 2025
@MJRichardson MJRichardson requested a review from Copilot June 17, 2025 04:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a serialization error encountered during change checks by updating the client serialization field, cleaning up outdated comments, and adjusting provider initialization in the README.

  • Remove obsolete TODO comments regarding HttpClient version verification.
  • Modify the serialization field’s access by making it public.
  • Bump the project version and update the README to use synchronous provider initialization.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/main/java/com/octopus/openfeature/provider/OctopusClient.java Removed TODO comments and updated the serialization field to public for proper deserialization.
pom.xml Updated the version from 0.1.0 to 0.2.0.
README.md Changed the provider initialization method from setProvider to setProviderAndWait for synchronous behavior.
Comments suppressed due to low confidence (2)

src/main/java/com/octopus/openfeature/provider/OctopusClient.java:98

  • Exposing the 'contentHash' field publicly fulfills the deserialization need; however, consider adding a comment or using proper annotations to document its intended usage and ensure clarity for future maintainers.
public byte[] contentHash;

README.md:84

  • Since the method was updated to setProviderAndWait to enforce synchronous initialization, update the accompanying documentation or comments to inform users of any potential blocking behavior introduced by this change.
openFeature.setProviderAndWait(new OctopusProvider(new OctopusConfiguration("Your Octopus client identifier")));

Copy link

@andrewabest andrewabest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look as expected and discussed.

@MJRichardson MJRichardson merged commit 3630164 into main Jun 17, 2025
2 checks passed
@MJRichardson MJRichardson deleted the michrich/contenthash-serialization-bug branch June 17, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when deserializing during check for changes

2 participants