Skip to content

Feat: Implement graph panning #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsh07 merged 4 commits into from
Nov 5, 2025
Merged

Feat: Implement graph panning #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f9afa3
fetching from parent repo
Satvik-Singh192 Oct 23, 2025
89d00a0
Feat: Implement graph panning (closes #6)
Satvik-Singh192 Oct 23, 2025
0e89f81
feat: added panning feature and resolved maintainers request
Satvik-Singh192 Oct 24, 2025
97d5b86
feat: panning works with implicit functions too now
Satvik-Singh192 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ profile.json
CMakeUserPresets.json
*.sublime-workspace
.idea/

.vs/
86 changes: 64 additions & 22 deletions src/core/Core/Application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,40 @@ ExitStatus App::Application::run() {
const ImVec2 canvas_p0 = ImGui::GetCursorScreenPos();
const ImVec2 canvas_sz = ImGui::GetContentRegionAvail();
const auto canvas_p1 = ImVec2(canvas_p0.x + canvas_sz.x, canvas_p0.y + canvas_sz.y);
const ImVec2 origin(canvas_p0.x + canvas_sz.x * 0.5f, canvas_p0.y + canvas_sz.y * 0.5f);
// --- PANNING IMPLEMENTATION BEGIN ---
static bool isPanning = false;
static ImVec2 lastMousePos = {0.0f, 0.0f};
static ImVec2 originOffset = {0.0f, 0.0f};

// Get mouse position
ImVec2 mousePos = ImGui::GetMousePos();

// Detect click start only when cursor is inside the graphing area
if (ImGui::IsWindowHovered() && ImGui::IsMouseClicked(ImGuiMouseButton_Left)) {
isPanning = true;
lastMousePos = mousePos;
}

// Stop panning when mouse released
if (ImGui::IsMouseReleased(ImGuiMouseButton_Left)) {
isPanning = false;
}

// While dragging, update origin offset
if (isPanning && ImGui::IsMouseDragging(ImGuiMouseButton_Left)) {
ImVec2 delta = ImVec2(mousePos.x - lastMousePos.x, mousePos.y - lastMousePos.y);
originOffset.x += delta.x;
originOffset.y += delta.y;
lastMousePos = mousePos;
}

// Apply offset to origin
const ImVec2 origin(
canvas_p0.x + canvas_sz.x * 0.5f + originOffset.x,
canvas_p0.y + canvas_sz.y * 0.5f + originOffset.y
);
// --- PANNING IMPLEMENTATION END ---

float lineThickness = 6.0f;

// --- Thin integer gridlines with adaptive spacing ---
Expand Down Expand Up @@ -228,12 +261,13 @@ ExitStatus App::Application::run() {
const double t_step = 0.02;

for (t = t_min; t <= t_max; t += t_step) {
const double vx = expr_fx.value();
const double vy = expr_gx.value();


ImVec2 screen_pos(origin.x + static_cast<float>(vx * zoom),
origin.y - static_cast<float>(vy * zoom));
const double vx = expr_fx.value();
const double vy = expr_gx.value();
// The 'origin' variable already includes the pan offset.
ImVec2 screen_pos(
origin.x + static_cast<float>(vx * zoom),
origin.y - static_cast<float>(vy * zoom)
);
points.push_back(screen_pos);
}

Expand Down Expand Up @@ -264,11 +298,11 @@ ExitStatus App::Application::run() {

if (parser.compile(func_str, expression)) {
// grid parameters
const double x_min = -canvas_sz.x / (2 * zoom);
const double x_max = canvas_sz.x / (2 * zoom);
const double y_min = -canvas_sz.y / (2 * zoom);
const double y_max = canvas_sz.y / (2 * zoom);

const double x_min = (-canvas_sz.x * 0.5f - originOffset.x) / zoom;
const double x_max = ( canvas_sz.x * 0.5f - originOffset.x) / zoom;
const double y_min = (-canvas_sz.y * 0.5f + originOffset.y) / zoom;
const double y_max = ( canvas_sz.y * 0.5f + originOffset.y) / zoom;
// adaptive step size with performance limit
const double step = std::max(0.025, 1.5 / zoom);
const ImU32 inequality_color = IM_COL32(100, 150, 255, 180);
Expand Down Expand Up @@ -346,10 +380,10 @@ ExitStatus App::Application::run() {

if (compile_ok) {
// grid parameters
const double x_min = -canvas_sz.x / (2 * zoom);
const double x_max = canvas_sz.x / (2 * zoom);
const double y_min = -canvas_sz.y / (2 * zoom);
const double y_max = canvas_sz.y / (2 * zoom);
const double x_min = (-canvas_sz.x * 0.5f - originOffset.x) / zoom;
const double x_max = ( canvas_sz.x * 0.5f - originOffset.x) / zoom;
const double y_min = (-canvas_sz.y * 0.5f + originOffset.y) / zoom;
const double y_max = ( canvas_sz.y * 0.5f + originOffset.y) / zoom;
const double step = std::max(0.008, 1.0 / zoom); //dynamic step based on zoom level

const ImU32 implicit_color = IM_COL32(64, 199, 128, 255);
Expand Down Expand Up @@ -473,12 +507,20 @@ ExitStatus App::Application::run() {
exprtk::parser<double> parser;
parser.compile(function, expression);

for (x = -canvas_sz.x / (2 * zoom); x < canvas_sz.x / (2 * zoom); x += 0.05) {
const double y = expression.value();

ImVec2 screen_pos(origin.x + x * zoom, origin.y - y * zoom);
points.push_back(screen_pos);
}
// Calculate the visible x-range in world-space, accounting for the pan
const float world_x_min = (-canvas_sz.x * 0.5f - originOffset.x) / zoom;
const float world_x_max = ( canvas_sz.x * 0.5f - originOffset.x) / zoom;

// Evaluate the function across the correct visible world-range
for (x = world_x_min; x <= world_x_max; x += 0.05) {
const double y = expression.value();
// The 'origin' variable already includes the pan offset.
ImVec2 screen_pos(
origin.x + static_cast<float>(x * zoom),
origin.y - static_cast<float>(y * zoom)
);
points.push_back(screen_pos);
}

draw_list->AddPolyline(points.data(),
points.size(),
Expand Down
Loading