Feat: Implement graph panning #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsh07
requested changes
Oct 23, 2025
Member
|
Also, can you please resolve the merge conflict? Thanks. |
Contributor
Author
|
@nsh07 i modified the .gitignore and resolved the merge conflicts too |
Member
|
Your current implementation does not seem to work with implicit relations: 
Your code looks perfect otherwise, I can continue with merging once you fix this. Thanks in advance! |
Member
|
Any updates? |
Member
|
Hey, you there? |
Contributor
Author
|
@nsh07 ah sorry, was busy in some stuff and travelling. i will look into resolving your request pretty soon....thanks |
Satvik-Singh192
force-pushed
the
feature/panning
branch
from
52a7bae to
97d5b86
Compare
Contributor
Author
|
@nsh07 i fixed the panning issue for implicit functions too, please review my pr |
nsh07
approved these changes
Nov 5, 2025
Member
|
Thank you so much for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the graph panning feature as described in issue #6.
The user can now click and drag the left mouse button within the graphing pane to move (pan) the Cartesian plane. This is achieved by:
originOffsetvariable.originOffsetto correctly calculate the final screen position of the origin axes and the plotted function points.Semver Changes
Issues
Closes #6
Checklist