Adds `System.Text.Json` serialization support to the NuGet plugin protocol by Nigusu-Allehu · Pull Request #7326 · NuGet/NuGet.Client

Nigusu-Allehu · 2026-04-27T15:35:53Z

Bug

Description

Adds System.Text.Json serialization support to the NuGet plugin protocol, gated behind a feature flag. When enabled plugin message serialization/deserialization uses STJ source-generated contexts

Key changes:

New STJ converters: MessageConverter, StjSemanticVersionConverter, StjTimeSpanConverter, RawJsonStringConverter, StjGetOperationClaimsResponseConverter
Feature-flag branching in Sender, StandardInputReceiver, and StandardOutputReceiver
Test coverage for both NSJ and STJ paths in MessageConverterTests
- These tests are a lot. Goal is to ensure there is parity when serializing and deserializing messages.

PR Checklist

Meaningful title, helpful description and a linked NuGet/Home issue
Added tests
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

Copilot

Pull request overview

Copilot reviewed 42 out of 43 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

src/NuGet.Core/NuGet.Protocol/Strings.Designer.cs: Language not supported

Copilot

Pull request overview

Copilot reviewed 42 out of 43 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

src/NuGet.Core/NuGet.Protocol/Strings.Designer.cs: Language not supported

nkolev92 · 2026-06-02T21:38:46Z

-
-                return stringWriter.ToString();
-            }
+            return JsonSerializer.Serialize(value, value.GetType(), PluginJsonContext.Default.Options);


nit: This class had a generic name and localized namespace with a generic implementation.

Now it has a generic name, localized namespaced with a localized implementation. I don't think renaming would be a bad idea.

merged but I will try to include this in another PR maybe.

Nigusu-Allehu self-assigned this Apr 27, 2026

Nigusu-Allehu mentioned this pull request Apr 29, 2026

[NSJ -> STJ]Migrate ServiceIndexResource deserialization #7297

Merged

3 tasks

Nigusu-Allehu force-pushed the dev-nyenework-plugin-stj branch 6 times, most recently from de5b915 to fb47bdc Compare May 6, 2026 23:40

Nigusu-Allehu requested a review from Copilot May 7, 2026 01:48

Copilot started reviewing on behalf of Nigusu-Allehu May 7, 2026 01:49 View session

This comment was marked as outdated.

Sign in to view

Nigusu-Allehu mentioned this pull request May 8, 2026

Replace JObject with object for Message.Payload #7376

Merged

3 tasks

dotnet-policy-service Bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label May 14, 2026

Nigusu-Allehu force-pushed the dev-nyenework-plugin-stj branch from fb47bdc to 2f86310 Compare May 14, 2026 14:20

dotnet-policy-service Bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label May 14, 2026

Nigusu-Allehu requested a review from Copilot May 14, 2026 16:31

Copilot started reviewing on behalf of Nigusu-Allehu May 14, 2026 16:32 View session

This comment was marked as outdated.

Sign in to view

dotnet-policy-service Bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label May 21, 2026

Start

422d5f5

Nigusu-Allehu force-pushed the dev-nyenework-plugin-stj branch from bcf5dca to 422d5f5 Compare May 27, 2026 01:39

dotnet-policy-service Bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label May 27, 2026

Nigusu-Allehu requested a review from Copilot May 27, 2026 01:41

Copilot started reviewing on behalf of Nigusu-Allehu May 27, 2026 01:41 View session

This comment was marked as outdated.

Sign in to view

cleanup

b31987f

Nigusu-Allehu requested a review from Copilot May 27, 2026 17:30

Copilot started reviewing on behalf of Nigusu-Allehu May 27, 2026 17:30 View session

This comment was marked as outdated.

Sign in to view

remove oblivious

a449f04

Nigusu-Allehu added 2 commits May 27, 2026 11:55

revert

bc2c143

revert

5ef01ab

Nigusu-Allehu requested a review from Copilot May 27, 2026 19:06

Copilot started reviewing on behalf of Nigusu-Allehu May 27, 2026 19:06 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread src/NuGet.Core/NuGet.Protocol/Plugins/MessageConverter.cs

Comment thread test/NuGet.Core.Tests/NuGet.Protocol.Tests/Plugins/Messages/MessageConverterTests.cs Outdated

fix

9fdc6d1

Nigusu-Allehu requested a review from Copilot May 27, 2026 19:30

Copilot started reviewing on behalf of Nigusu-Allehu May 27, 2026 19:31 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

fix tests

526b42b

Copilot started work on behalf of Nigusu-Allehu May 27, 2026 20:15 View session

Copilot finished work on behalf of Nigusu-Allehu May 27, 2026 20:18

Nigusu-Allehu marked this pull request as ready for review May 27, 2026 20:25

Nigusu-Allehu requested a review from a team as a code owner May 27, 2026 20:25

Nigusu-Allehu requested review from kartheekp-ms and nkolev92 May 27, 2026 20:25

jeffkl previously approved these changes May 28, 2026

View reviewed changes

nkolev92 reviewed May 28, 2026

View reviewed changes

Comment thread src/NuGet.Core/NuGet.Protocol/Plugins/Messages/GetOperationClaimsResponse.cs Outdated

remove converter

3dbc785

Nigusu-Allehu dismissed jeffkl’s stale review via 3dbc785 May 28, 2026 22:06

cleanup

0d2749c

Nigusu-Allehu requested a review from nkolev92 May 28, 2026 22:31

nkolev92 reviewed May 29, 2026

View reviewed changes

Comment thread src/NuGet.Core/NuGet.Protocol/Plugins/MessageConverter.cs Outdated

Comment thread src/NuGet.Core/NuGet.Protocol/Plugins/StjTimeSpanConverter.cs Outdated

null and remove converter

bbb6ded

Nigusu-Allehu requested a review from nkolev92 June 1, 2026 20:06

nkolev92 approved these changes Jun 2, 2026

View reviewed changes

jeffkl approved these changes Jun 2, 2026

View reviewed changes

Nigusu-Allehu merged commit 76e5f30 into dev Jun 2, 2026
17 of 18 checks passed

Nigusu-Allehu deleted the dev-nyenework-plugin-stj branch June 2, 2026 23:24

dotnet-maestro Bot mentioned this pull request Jun 3, 2026

[release/10.0.4xx] Source code updates from nuget/nuget.client dotnet/dotnet#6985

Open

Conversation

Nigusu-Allehu commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug

Description

PR Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkolev92 Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Nigusu-Allehu Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nigusu-Allehu commented Apr 27, 2026 •

edited

Loading