[NSJ -> STJ]Migrate ServiceIndexResource deserialization#7297
Merged
Conversation
richlander
reviewed
Apr 17, 2026
richlander
reviewed
Apr 17, 2026
richlander
reviewed
Apr 17, 2026
richlander
reviewed
Apr 17, 2026
richlander
reviewed
Apr 17, 2026
richlander
reviewed
Apr 17, 2026
Nigusu-Allehu
force-pushed
the
dev-nyenework-serevice-deserialization-stj
branch
from
eec8cde to
0bd78f3
Compare
dotnet-policy-service
Bot
added
the
Status:No recent activity
Nigusu-Allehu
force-pushed
the
dev-nyenework-serevice-deserialization-stj
branch
from
0bd78f3 to
ec0c0f7
Compare
Nigusu-Allehu
changed the base branch from
dev-feature-nsj-stj-migration
to
dev
dotnet-policy-service
Bot
removed
the
Status:No recent activity
nkolev92
reviewed
Apr 28, 2026
nkolev92
reviewed
Apr 29, 2026
zivkan
reviewed
Apr 30, 2026
nkolev92
reviewed
Apr 30, 2026
Member
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
I think this is good now.
I have 2 comments, 1 should be addressed, the other one is an idea.
nkolev92
previously approved these changes
May 1, 2026
jeffkl
previously approved these changes
May 5, 2026
jeffkl
reviewed
May 5, 2026
Member
Author
|
rebased |
Nigusu-Allehu
force-pushed
the
dev-nyenework-serevice-deserialization-stj
branch
from
f4bb7c3 to
9cbf288
Compare
nkolev92
approved these changes
May 6, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14886
Related: NuGet/Home#14846
Description
Adds
ServiceIndexModelPOCOs and migratesConsumeServiceIndexStreamAsyncto support STJ source generation. The existingJObjectconstructor and callers are unchanged.PR Checklist