[TRTLLM-12440][feat] Add GMS-only weight sharing support#13926
Draft
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
Draft
[TRTLLM-12440][feat] Add GMS-only weight sharing support#13926chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #47456 [ run ] triggered by Bot. Commit: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Summary
Adds
LoadFormat.GMSso multiple TRT-LLM instances on the same node can zero-copy share model weights via the GPU Memory Service (GMS) pool. The first instance loads weights as the writer (RW); subsequent peers materialize them read-only (RO) without disk I/O or per-instance copies.Scope
In scope:
LoadFormat.GMSenum value and nestedGmsConfig(socket_path,mode,tag) onTorchLlmArgs.GMSBackendadapter undertensorrt_llm/_torch/memory/, lazily imported only when GMS is selected.ModelLoaderGMS branch with explicit RW / RO / unexpected-state handling, plus a guard that refuses to commit an unpopulated model to the pool.PyTorchModelEngine.__del__.Adjacent (sub-PR, ~15 lines): remove the redundant
MXCheckpointLoader.p2p_succeededproperty;is_weights_preloaded()(the abstract hook fromBaseCheckpointLoader) is now the single accessor. Tests updated accordingly.Out of scope:
LoadFormat.GMS).gpu_memory_servicedependency. Same OSS-allowlist concern as MX; users install it manually for now.Test Coverage
New unit test files (mock-based, CPU CI):
tests/unittest/llmapi/test_gms_args.py—GmsConfigvalidation andLoadFormat.GMSPydantic surface.tests/unittest/_torch/memory/test_gms_backend.py—GMSBackendlifecycle and helpers.tests/unittest/_torch/pyexecutor/test_model_loader_gms.py—ModelLoaderGMS RW / RO / failure / edge-case branches.Updated:
tests/unittest/_torch/models/checkpoints/mx/test_mx_checkpoint_loader.py— six call sites switched tois_weights_preloaded()after removing the redundantp2p_succeededproperty.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.