[None][test] Add checkpoint_format / load_format keys to test_features_contract#13933
Open
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
Open
[None][test] Add checkpoint_format / load_format keys to test_features_contract#13933chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…s_contract Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Contributor
📝 WalkthroughWalkthroughThe telemetry contract test ChangesTelemetry Contract Assertions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #47489 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Summary
Refresh
test_features_contract.test_all_features_enabled_real_configsto match the post-#13531 telemetry payload. The MX-only PR addedcheckpoint_formatandload_formattousage_lib._FEATURES_DEFAULTSand updatedtest_llm_telemetryto derive expected keys dynamically, but missed this hardcoded expected dict — so the test has been failing on every fresh checkout ofmainever since.This change adds the two missing keys to the expected payload with their default values (
HF/AUTO, since the test doesn't override either field). No production code changes.Test Plan
pytest tests/unittest/llmapi/test_features_contract.py— 22/22 pass locally.Related
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.