Skip to content

[None][test] Add checkpoint_format / load_format keys to test_features_contract#13933

Open
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
chienchunhung:fix-features-contract-test
Open

[None][test] Add checkpoint_format / load_format keys to test_features_contract#13933
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
chienchunhung:fix-features-contract-test

Conversation

@chienchunhung
Copy link
Copy Markdown
Collaborator

@chienchunhung chienchunhung commented May 9, 2026

Summary by CodeRabbit

  • Tests
    • Enhanced telemetry contract test to verify additional feature payload fields with their default values.

Review Change Stack

Summary

Refresh test_features_contract.test_all_features_enabled_real_configs to match the post-#13531 telemetry payload. The MX-only PR added checkpoint_format and load_format to usage_lib._FEATURES_DEFAULTS and updated test_llm_telemetry to derive expected keys dynamically, but missed this hardcoded expected dict — so the test has been failing on every fresh checkout of main ever since.

This change adds the two missing keys to the expected payload with their default values (HF / AUTO, since the test doesn't override either field). No production code changes.

Test Plan

  • pytest tests/unittest/llmapi/test_features_contract.py — 22/22 pass locally.

Related

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…s_contract

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
@chienchunhung chienchunhung requested a review from venkywonka May 9, 2026 07:03
@chienchunhung chienchunhung marked this pull request as ready for review May 9, 2026 07:03
@chienchunhung chienchunhung changed the title None][test] Add checkpoint_format / load_format keys to test_features_contract [None][test] Add checkpoint_format / load_format keys to test_features_contract May 9, 2026
@chienchunhung chienchunhung enabled auto-merge (squash) May 9, 2026 07:04
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

📝 Walkthrough

Walkthrough

The telemetry contract test test_all_features_enabled_real_configs is extended with assertions for two new feature payload fields: checkpoint_format ("HF") and load_format ("AUTO"). Inline comments clarify these are MX-only telemetry keys with defaults when the corresponding configuration parameters are not overridden.

Changes

Telemetry Contract Assertions

Layer / File(s) Summary
Test Assertion Update
tests/unittest/llmapi/test_features_contract.py
Expected telemetry payload expanded to assert checkpoint_format: "HF" and load_format: "AUTO" in fully-enabled configuration, with comments noting these are MX-only defaults from PR #13531.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding two telemetry payload keys to a unit test assertion.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description comprehensively explains the issue, solution, test coverage, and related PRs. It clearly documents what changed and why, with proper context about the failing test and its fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@chienchunhung
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47489 [ run ] triggered by Bot. Commit: 0b0245c Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants