Skip to content

chore: export ConstraintType and InequalityOperator from config init #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnnygreco wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

chore: export ConstraintType and InequalityOperator from config init #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc3301
update init constraint imports
johnnygreco Feb 6, 2026
2475146
add missing columns
johnnygreco Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,8 @@ When working with column configurations, understand these key types:
- **`ExpressionColumnConfig`**: Expression-based derived columns (Python eval or Jinja2)
- **`ValidationColumnConfig`**: Validation results (Python, SQL, Code, Remote validators)
- **`SeedDatasetColumnConfig`**: Data from seed datasets
Comment on lines 507 to 509
Copy link

@greptile-apps greptile-apps bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR metadata mismatch

This PR is described as exporting ConstraintType/InequalityOperator from config/__init__.py, but this commit only changes AGENTS.md (and even git show for the head SHA lists only AGENTS.md). If this is the intended PR content, please update the PR title/description and changed-files list; otherwise, the actual code change for packages/data-designer-config/src/data_designer/config/__init__.py is missing from the head commit(s) and needs to be included before merge.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: AGENTS.md
Line: 507:509

Comment:
**PR metadata mismatch**

This PR is described as exporting `ConstraintType`/`InequalityOperator` from `config/__init__.py`, but this commit only changes `AGENTS.md` (and even `git show` for the head SHA lists only `AGENTS.md`). If this is the intended PR content, please update the PR title/description and changed-files list; otherwise, the actual code change for `packages/data-designer-config/src/data_designer/config/__init__.py` is missing from the head commit(s) and needs to be included before merge.

How can I resolve this? If you propose a fix, please make it concise.

- **`EmbeddingColumnConfig`**: Embedding generation for text columns using a specified model
- **`CustomColumnConfig`**: Custom user-defined column generators via `@custom_column_generator` decorator

See [packages/data-designer-config/src/data_designer/config/column_configs.py](packages/data-designer-config/src/data_designer/config/column_configs.py) for detailed schemas.

Expand Down
4 changes: 4 additions & 0 deletions packages/data-designer-config/src/data_designer/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@
from data_designer.config.run_config import RunConfig # noqa: F401
from data_designer.config.sampler_constraints import ( # noqa: F401
ColumnInequalityConstraint,
ConstraintType,
InequalityOperator,
ScalarInequalityConstraint,
)
from data_designer.config.sampler_params import ( # noqa: F401
Expand Down Expand Up @@ -168,6 +170,8 @@
"RunConfig": (f"{_MOD_BASE}.run_config", "RunConfig"),
# sampler_constraints
"ColumnInequalityConstraint": (_MOD_SAMPLER_CONSTRAINTS, "ColumnInequalityConstraint"),
"ConstraintType": (_MOD_SAMPLER_CONSTRAINTS, "ConstraintType"),
"InequalityOperator": (_MOD_SAMPLER_CONSTRAINTS, "InequalityOperator"),
"ScalarInequalityConstraint": (_MOD_SAMPLER_CONSTRAINTS, "ScalarInequalityConstraint"),
# sampler_params
"BernoulliMixtureSamplerParams": (_MOD_SAMPLER_PARAMS, "BernoulliMixtureSamplerParams"),
Expand Down