chore: export ConstraintType and InequalityOperator from config init#308
Open
johnnygreco wants to merge 2 commits intomainfrom
Open
chore: export ConstraintType and InequalityOperator from config init#308johnnygreco wants to merge 2 commits intomainfrom
johnnygreco wants to merge 2 commits intomainfrom
Conversation
Greptile OverviewGreptile Summary
|
| Filename | Overview |
|---|---|
| AGENTS.md | Updates the guidance list of column configuration types (adds EmbeddingColumnConfig and CustomColumnConfig), but the PR metadata/description claims unrelated config public API exports. |
| packages/data-designer-config/src/data_designer/config/init.py | Adds lazy exports for ConstraintType and InequalityOperator plus TYPE_CHECKING imports; change itself is straightforward and consistent with existing lazy import pattern. |
Sequence Diagram
sequenceDiagram
participant User as User code
participant Config as data_designer.config (__init__)
participant Importlib as importlib
participant SC as data_designer.config.sampler_constraints
User->>Config: import data_designer.config as dd
User->>Config: access dd.ConstraintType
Config->>Config: __getattr__("ConstraintType")
Config->>Importlib: import_module("data_designer.config.sampler_constraints")
Importlib-->>SC: load module
SC-->>Config: module object
Config->>SC: getattr(ConstraintType)
SC-->>User: ConstraintType Enum
Comment on lines
507
to
509
| - **`ExpressionColumnConfig`**: Expression-based derived columns (Python eval or Jinja2) | ||
| - **`ValidationColumnConfig`**: Validation results (Python, SQL, Code, Remote validators) | ||
| - **`SeedDatasetColumnConfig`**: Data from seed datasets |
There was a problem hiding this comment.
PR metadata mismatch
This PR is described as exporting ConstraintType/InequalityOperator from config/__init__.py, but this commit only changes AGENTS.md (and even git show for the head SHA lists only AGENTS.md). If this is the intended PR content, please update the PR title/description and changed-files list; otherwise, the actual code change for packages/data-designer-config/src/data_designer/config/__init__.py is missing from the head commit(s) and needs to be included before merge.
Prompt To Fix With AI
This is a comment left during a code review.
Path: AGENTS.md
Line: 507:509
Comment:
**PR metadata mismatch**
This PR is described as exporting `ConstraintType`/`InequalityOperator` from `config/__init__.py`, but this commit only changes `AGENTS.md` (and even `git show` for the head SHA lists only `AGENTS.md`). If this is the intended PR content, please update the PR title/description and changed-files list; otherwise, the actual code change for `packages/data-designer-config/src/data_designer/config/__init__.py` is missing from the head commit(s) and needs to be included before merge.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Exports
ConstraintTypeandInequalityOperatorfrom thedata_designer.configpublic API so users can access these constraint-related types directly viaimport data_designer.config as dd.🔄 Changes
✨ Added
ConstraintTypeandInequalityOperatorto theTYPE_CHECKINGimports inconfig/__init__.pyfor IDE supportConstraintTypeandInequalityOperatorto the_LAZY_IMPORTSdict for runtime lazy loading🤖 Generated with AI
Made with Cursor