Skip to content

feat(bindings): tgeompoint operations parity — distance / affine / transforms / geoMeasure#99

Open
estebanzimanyi wants to merge 1 commit intomainfrom
consolidate/tgeompoint-ops-parity
Open

feat(bindings): tgeompoint operations parity — distance / affine / transforms / geoMeasure#99
estebanzimanyi wants to merge 1 commit intomainfrom
consolidate/tgeompoint-ops-parity

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

@estebanzimanyi estebanzimanyi commented May 4, 2026

👀 Reviewers: tier ranking, dependency chains and the standards checklist live in doc/contributing/reviewer-guide.md.

Summary

Consolidates 4 individual parity PRs (previously #64, #65, #69, #84) into one squashed commit.

  • tgeompoint distance + temporal-position predicates (NAD, |=|, NAI, shortestLine, |>>, <<|, etc.)
  • tgeompoint affine and derived spatial transforms (affine matrix, rotate, scale, translate, snap-to-grid)
  • tgeompoint transform stragglers: rotate-around-point + scale-by-doubles
  • asMVTGeom + geoMeasure for tgeompoint

Test plan

  • test/sql/parity/025_temporal_tile.test
  • test/sql/parity/038_temporal_similarity.test
  • No regressions in existing tgeompoint tests

🤖 Generated with Claude Code

@estebanzimanyi
Copy link
Copy Markdown
Member Author

Cross-reference: docs/CONSOLIDATION-PLAN.md on #115

This PR's surface overlaps with parity commits already on main (e41c8d9 → c8cad6d). The overlap matrix and three resolution options per overlap (rebase / revert+fold / keep both) are documented in docs/CONSOLIDATION-PLAN.md on #115. Maintainer's call which path to take per PR.

estebanzimanyi added a commit that referenced this pull request May 10, 2026
Two new docs:
- docs/PR-COORDINATION.md — ecosystem policy: gh pr list is the first
  step before any code change; don't duplicate or conflict with
  in-flight PRs/policies. Cross-ecosystem variant. One PR = one commit
  = one feature consolidation rule with the git commit-tree squash
  recipe.
- docs/CONSOLIDATION-PLAN.md — working artefact mapping the file-level
  overlap between commits already on main and the open consolidate/*
  parity PRs (#97/#98/#99/#100/#102/#103/#104) plus PR #111
  (per-thread MEOS init). Three resolution options per overlap
  (rebase / revert+fold / keep both); maintainer picks per PR.

Pre-emptive policy preventing the duplication and policy-conflict
failures that produced the consolidate/* / main overlap and the
single-timezone / per-thread-MEOS-init clash.
…ansforms / geoMeasure

Brings the tgeompoint operations surface to parity with MobilityDB:

- tdistance / NAI / NAD / shortestLine — distance and nearest-approach
  family between tgeompoint and geometry / tgeompoint pairs.
- Affine transformations — rotate, scale, translate, transform
  combinations, plus the corresponding *Pipeline overloads.
- Position predicates — temporal_left/right/above/below/front/back and
  their over* variants, exposed as named functions and operators where
  DuckDB's parser allows.
- asMVTGeom — vector-tile geometry serialisation.
- geoMeasure — measured-trajectory distance accumulator.

Also registers the tdistance/NAI/NAD/affine/transform entries that were
omitted from the initial parity pass, completing the function table for
this surface.
@estebanzimanyi estebanzimanyi force-pushed the consolidate/tgeompoint-ops-parity branch from 963bca9 to 6154d03 Compare May 10, 2026 13:28
estebanzimanyi added a commit that referenced this pull request May 10, 2026
…nsolidates #115 + #119)

Three related artefacts that prevent the same class of failure (parallel
work on the same surface drifting in policy and offset state):

docs/PR-COORDINATION.md — ecosystem policy: gh pr list is the first
step before any code change; minimise PR count by folding into existing
PRs; squash each PR to a single commit before review.  Cross-ecosystem
variant for MobilityDB / JMEOS / PyMEOS / MobilitySpark / MEOS-API.

docs/CONSOLIDATION-PLAN.md — file-level overlap matrix between commits
already on main and the open consolidate/* parity PRs (#97/#98/#99/
#100/#102/#103/#104) plus PR #111 (per-thread MEOS init); three
resolution options per overlap.  Working artefact, delete once
consolidations land.

scripts/lint-tz-pinned-tests.py — flags every line in an
expected-output block that carries a hardcoded UTC offset.  Pre-commit
gate / CI lint.  Today reports 734 hits across 43 files; the lint
makes the timezone-neutral migration trackable.

scripts/parity-audit.py — adds an OUT_OF_SCOPE_NAMES bucket for
function names that are out-of-scope by domain (not by suffix
pattern):
- transform_gk: Gauss-Krüger projection added to MobilityDB for the
  SECONDO platform integration; no equivalent need in MobilityDuck.
- create_trip: BerlinMOD synthetic-trip generator; runs in
  MobilityDB / SECONDO and emits parquet artefacts that MobilityDuck
  consumes — MobilityDuck does not need to host the generator itself.

Pairs naturally with PR #111 / commit 9dd765a's timezone-neutral test
policy: the doc tells contributors what to do, the lint enforces it,
the parity audit reflects realistic coverage now that two domain-
specific names are off the missing list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant