feat(geo): add nearestApproachDistance, expandSpace, && for TGEOMPOINT#114
Open
estebanzimanyi wants to merge 1 commit intofeat/edge-to-cloud-quickstartfrom
Open
feat(geo): add nearestApproachDistance, expandSpace, && for TGEOMPOINT#114estebanzimanyi wants to merge 1 commit intofeat/edge-to-cloud-quickstartfrom
estebanzimanyi wants to merge 1 commit intofeat/edge-to-cloud-quickstartfrom
Conversation
Register three MEOS-backed function overloads needed for portable BerlinMOD queries: - overlaps_tspatial_tspatial → &&(TGEOMPOINT, TGEOMPOINT) - nad_tgeo_tgeo → nearestApproachDistance(TGEOMPOINT, TGEOMPOINT) - tspatial_to_stbox + stbox_expand_space → expandSpace(TGEOMPOINT, DOUBLE)
d88b909 to
e3c62fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three MEOS-backed functions that complete BerlinMOD portable SQL coverage on MobilityDuck:
nearestApproachDistance(TGEOMPOINT, TGEOMPOINT) → DOUBLE— wrapsnad_tgeo_tgeo; returns NULL (not 0) when trips have no overlapping time extent (sentinelDBL_MAX→ SQL NULL viaExecuteWithNulls)expandSpace(TGEOMPOINT, DOUBLE) → STBOX— wrapstspatial_to_stbox+stbox_expand_space; enables thetrip && expandSpace(other, dist)index pre-filter in Q10&&(TGEOMPOINT, TGEOMPOINT) → BOOLEAN— wrapsoverlaps_tspatial_tspatial; STBox overlap pre-filter for cross-trip joinsBerlinMOD impact:
nearestApproachDistanceexpandSpace16/18 queries already worked on the released community extension; this adds the missing 2.
Stacked on: #113 (edge-to-cloud quickstart + SRID/geodetic fix). Merge #113 first; GitHub will rebase this PR onto
mainautomatically.Cross-references:
Test plan
nearestApproachDistance(trip1, trip2)returns correct float, NULL when disjoint in timeexpandSpace(trip, 3.0)returns STBox expanded by 3 units spatially./berlinmod/run_mduck.shfrom MobilitySpark