Skip to content

GEOPY-2419: create a function in run.py to run from an outgroup#156

Closed
MatthieuCMira wants to merge 20 commits intodevelopfrom
GEOPY-2419
Closed

GEOPY-2419: create a function in run.py to run from an outgroup#156
MatthieuCMira wants to merge 20 commits intodevelopfrom
GEOPY-2419

Conversation

@MatthieuCMira
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira commented Sep 8, 2025

GEOPY-2419 - create a function in run.py to run from an outgroup
add a run function so we can fully run an application from a uijson

Test errors for coverage is missing
@github-actions github-actions bot changed the title Geopy 2419 GEOPY-2419: create a function in run.py to run from an outgroup Sep 8, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 94.80519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.05%. Comparing base (d697a86) to head (34d49e5).
⚠️ Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
geoapps_utils/run.py 94.28% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #156      +/-   ##
===========================================
+ Coverage    85.17%   86.05%   +0.87%     
===========================================
  Files           19       19              
  Lines         1012     1083      +71     
  Branches       134      146      +12     
===========================================
+ Hits           862      932      +70     
+ Misses         113      112       -1     
- Partials        37       39       +2     
Files with missing lines Coverage Δ
geoapps_utils/base.py 91.17% <100.00%> (+2.08%) ⬆️
geoapps_utils/run.py 92.07% <94.28%> (+3.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

push befor emerging
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	geoapps_utils/base.py
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
#	tests/driver_test.py
@MatthieuCMira
Copy link
Copy Markdown
Contributor Author

need a relock once 2465 is merged into develop

@domfournier
Copy link
Copy Markdown
Contributor

domfournier commented Sep 19, 2025

As an aside, I tested again and it IS possible to have multi-threads reading the same file at once, BUT none of them can be in "r+". They all need to be forced to be in mode "r" only.

@MatthieuCMira
Copy link
Copy Markdown
Contributor Author

So the method copy relative with only opened "r" file could work.
So what is the benefice of shutil?

Simplify functions
domfournier
domfournier previously approved these changes Sep 23, 2025
…provided"This reverts commit c3eeae5.

Revert "Fix naming of output uijson and geoh5"

This reverts commit 1d5de18.
@domfournier
Copy link
Copy Markdown
Contributor

PR replaced by #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants