GEOPY-2419: create a function in run.py to run from an outgroup#156
Closed
MatthieuCMira wants to merge 20 commits intodevelopfrom
Closed
GEOPY-2419: create a function in run.py to run from an outgroup#156MatthieuCMira wants to merge 20 commits intodevelopfrom
MatthieuCMira wants to merge 20 commits intodevelopfrom
Conversation
Test errors for coverage is missing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
===========================================
+ Coverage 85.17% 86.05% +0.87%
===========================================
Files 19 19
Lines 1012 1083 +71
Branches 134 146 +12
===========================================
+ Hits 862 932 +70
+ Misses 113 112 -1
- Partials 37 39 +2
🚀 New features to boost your workflow:
|
domfournier
reviewed
Sep 9, 2025
push befor emerging
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # geoapps_utils/base.py # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # py-3.12.conda-lock.yml # tests/driver_test.py
…e in different scenarios. No test
Contributor
Author
|
need a relock once 2465 is merged into develop |
domfournier
reviewed
Sep 19, 2025
domfournier
reviewed
Sep 19, 2025
Contributor
|
As an aside, I tested again and it IS possible to have multi-threads reading the same file at once, BUT none of them can be in "r+". They all need to be forced to be in mode "r" only. |
Contributor
Author
|
So the method copy relative with only opened "r" file could work. |
Simplify functions
domfournier
reviewed
Sep 22, 2025
Use load_uijson_as_dict for shutil option to speed things
domfournier
reviewed
Sep 22, 2025
accept InputFile as input of start driver fucntion
domfournier
previously approved these changes
Sep 23, 2025
Contributor
|
PR replaced by #163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2419 - create a function in run.py to run from an outgroup
add a run function so we can fully run an application from a uijson