Skip to content

Conversation

@TD-D
Copy link

@TD-D TD-D commented May 15, 2014

Signed-off-by: TD-D orenfza@gmail.com

Merp and others added 20 commits April 21, 2014 22:20
…base map calculator spreadsheet with timing tables.
…llows communication of ram variable storage type instead of byte length and increases the characters allowed for the parameter id.
…inition tables, added inejctor scalar hack, and added hack calls to main routine for monitoring.
…added preprocessor conditionals for targets without brake switch, and fixed bug in test 6.
Signed-off-by: TD-D <orenfza@gmail.com>
@Merp
Copy link
Owner

Merp commented May 15, 2014

Looks good, add the config header file as well. I'll leave this open until we get some testing feedback. In the meantime once you get the definitions pushed (branch: MerpMod_dev_AZ1G202G), we can put links up for testing. Either send them to me through IRC/email or just post in the RR thread and I'll update the OP.

@TD-D
Copy link
Author

TD-D commented May 15, 2014

In terms of the config header file, we're talking AZ1G202GConfig.h ? The
file is already in there?

Ok - I've pushed the definitions to a new branch MerpMod_dev_AZ1G202G.
Incidentally, I've noticed three small bugs with the generation of the
ecuflash definition - the X axis is not being created for the following
maps:

Map Blending Injector Scaling
TGV Left Input Scaling
TGV Right Input Scaling

I've had to manually input them,

Cheers,
Oren

On Thu, May 15, 2014 at 5:42 PM, Merp notifications@github.com wrote:

Looks good, add the config header file as well. I'll leave this open until
we get some testing feedback. In the meantime once you get the definitions
pushed (branch: MerpMod_dev_AZ1G202G), we can put links up for testing.
Either send them to me through IRC/email or just post in the RR thread and
I'll update the OP.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-43226390
.

@Merp
Copy link
Owner

Merp commented May 15, 2014

That's right, I did a gratis version so it's already there. The 2D table
issue is fixed in some ST commits I am working on. I will push it to dev
soon but want to do some more testing before release.
On May 15, 2014 3:06 PM, "TD-D" notifications@github.com wrote:

In terms of the config header file, we're talking AZ1G202GConfig.h ? The
file is already in there?

Ok - I've pushed the definitions to a new branch MerpMod_dev_AZ1G202G.
Incidentally, I've noticed three small bugs with the generation of the
ecuflash definition - the X axis is not being created for the following
maps:

Map Blending Injector Scaling
TGV Left Input Scaling
TGV Right Input Scaling

I've had to manually input them,

Cheers,
Oren

On Thu, May 15, 2014 at 5:42 PM, Merp notifications@github.com wrote:

Looks good, add the config header file as well. I'll leave this open
until
we get some testing feedback. In the meantime once you get the
definitions
pushed (branch: MerpMod_dev_AZ1G202G), we can put links up for testing.
Either send them to me through IRC/email or just post in the RR thread
and
I'll update the OP.


Reply to this email directly or view it on GitHub<
https://github.com/Merp/MerpMod/pull/3#issuecomment-43226390>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-43251819
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants