Skip to content

Commit be49b49

Browse files
MerpMerp
authored andcommitted
Rename timing hack variables for clarity. Add variable to show base timing.
1 parent 2a73b36 commit be49b49

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

MerpMod/Definition.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -515,8 +515,9 @@ DEFINERAMVAR("MerpMod LC Timing Mode",LCTimingMode,"uint8","E");
515515
DEFINERAMVAR("MerpMod LC Timing Lock Value",LCTimingLock,"float","E");
516516
DEFINERAMVAR("MerpMod LC Timing Retard",LCTimingRetard,"float","E");
517517
DEFINERAMVAR("MerpMod LC Timing Retard Multiplier",LCTimingRetardMultiplier,"float","E");
518-
DEFINERAMVAR("MerpMod Base Timing Final Target",BaseTimingTarget,"float","E");
519-
DEFINERAMVAR("MerpMod Base Timing Final Output",BaseTimingOutput,"float","E");
518+
DEFINERAMVAR("MerpMod Base Timing",BaseTiming,"float","E");
519+
DEFINERAMVAR("MerpMod Final Timing",FinalTiming,"float","E");
520+
DEFINERAMVAR("MerpMod Timing Output",TimingOutput,"float","E");
520521

521522
DEFNEW1D("Launch Control Timing Mode",DefaultLCTimingMode);
522523
DEFNEW1D("Launch Control Timing Lock",DefaultLCTimingLock);

MerpMod/Metadata.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ const MetaReplace POLFHook METADATA =
488488
op: OpReplace4Bytes,
489489
address: hTableBaseTiming,
490490
oldval: tBaseTiming,
491-
newval: (int)&(pRamVariables.BaseTimingOutput),
491+
newval: (int)&(pRamVariables.TimingOutput),
492492
name: STR(Timing Table Hook)
493493
};
494494
#else
@@ -497,7 +497,7 @@ const MetaReplace POLFHook METADATA =
497497
op: OpReplace4Bytes,
498498
address: hTableBaseTimingPCruise,
499499
oldval: tBaseTimingPCruise,
500-
newval: (int)&(pRamVariables.BaseTimingOutput),
500+
newval: (int)&(pRamVariables.TimingOutput),
501501
name: STR(Base Timing Primary Cruise Table Hook)
502502
};
503503
const MetaReplace BaseTimingPNonCruiseTablePatch METADATA =

MerpMod/RamVariables.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,9 @@ typedef struct
137137
unsigned char LCTimingMode;
138138
unsigned char TimingHackEnabled;
139139
unsigned char Tempty1;
140-
float BaseTimingTarget;
141-
float BaseTimingOutput; //97
140+
float BaseTiming;
141+
float FinalTiming; //97
142+
float TimingOutput;
142143
float LCTimingRetard; //97
143144
float LCTimingLock; //97
144145
float LCTimingLockRPM;

MerpMod/TableHackTests.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,16 @@ void TimingHackUnitTests()
4343
Assert(pRamVariables.LCTimingLock == DefaultLCTimingLock, "check timing lock default value");
4444
Assert(pRamVariables.MapBlendRatio == DefaultBlend, "Check default blending value");
4545
Assert(pRamVariables.TimingHackInitFlag == 0x01, "Check Timing init flag is set");
46-
Assert(pRamVariables.BaseTimingOutput == -12.96875, "check timing map 1 is used");
46+
Assert(pRamVariables.TimingOutput == -12.96875, "check timing map 1 is used");
4747

4848
pRamVariables.MapBlendRatio = 1;
4949
TimingHack();
50-
Assert(pRamVariables.BaseTimingOutput == -20, "check timing map 1 is used");
50+
Assert(pRamVariables.TimingOutput == -20, "check timing map 1 is used");
5151

5252

5353
pRamVariables.MapBlendRatio = 0.5;
5454
TimingHack();
55-
Assert(pRamVariables.BaseTimingOutput == ((-12.96875 - 20)/2), "check timing map 1 is used");
55+
Assert(pRamVariables.TimingOutput == ((-12.96875 - 20)/2), "check timing map 1 is used");
5656

5757
pRamVariables.LCTimingMode = LCTimingModeLocked; //Set locked timing, default is +20
5858

MerpMod/TimingHacks.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ float TimingHack()
4545
#endif
4646

4747
OutputValue = BlendAndSwitch(TimingTableGroup, *pEngineLoad, *pEngineSpeed);
48+
pRamVariables.BaseTiming = OutputValue;
4849

4950
#if TIMING_RAM_TUNING
5051
}
@@ -65,12 +66,12 @@ float TimingHack()
6566

6667
OutputValue -= Abs(pRamVariables.SubtractiveKCA);
6768

68-
pRamVariables.BaseTimingTarget = OutputValue;
69+
pRamVariables.FinalTiming = OutputValue;
6970

7071
if(pRamVariables.TimingHackEnabled == HackEnabled)
71-
pRamVariables.BaseTimingOutput = OutputValue;
72+
pRamVariables.TimingOutput = OutputValue;
7273
else
73-
pRamVariables.BaseTimingOutput = Pull3DHooked((void*)PrimaryOEMTimingTable, *pEngineLoad, *pEngineSpeed);
74+
pRamVariables.TimingOutput = Pull3DHooked((void*)PrimaryOEMTimingTable, *pEngineLoad, *pEngineSpeed);
7475

7576
//Call existing!
7677
BaseTimingHooked();

0 commit comments

Comments
 (0)