Skip to content

Conversation

@JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Jun 12, 2025

Sending of logs should be handled by python client. That should take responsibilities of Mergin QGIS plugin, which should only pass paths to log files and necessary info.

Adds two helper functions - server_config() and server_version_newer_or_equal_than() which should be useful in the long term. server_version_newer_or_equal_than() might need some more robust check if the passed required_version is a correct string.

@JanCaha JanCaha requested a review from MarcelGeo June 12, 2025 10:55
Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I am not sure if we need another version support function :)

@MarcelGeo MarcelGeo added this to the 0.10.1 milestone Jun 12, 2025
@coveralls
Copy link

coveralls commented Jun 12, 2025

Pull Request Test Coverage Report for Build 15631070300

Details

  • 47 of 57 (82.46%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 80.047%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/client.py 25 35 71.43%
Totals Coverage Status
Change from base Build 15386659816: 0.03%
Covered Lines: 3426
Relevant Lines: 4280

💛 - Coveralls

@JanCaha JanCaha merged commit e7f1c66 into master Jun 13, 2025
4 checks passed
@JanCaha JanCaha deleted the send-logs branch June 13, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants