Skip to content

Conversation

@JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Jun 12, 2025

Simplify sending the logs by moving the logic to mergin-client

Fixes #633

@JanCaha
Copy link
Contributor Author

JanCaha commented Jun 13, 2025

@ValentinBuira bigger part of the code was actually moved from plugin to the mergin-client, it is already merged there MerginMaps/python-api-client#243.

@tomasMizera tomasMizera merged commit 6598e27 into master Jul 24, 2025
7 checks passed
@tomasMizera tomasMizera deleted the send-logs branch July 24, 2025 10:51
@JanCaha JanCaha restored the send-logs branch July 24, 2025 12:54
@RastoHu
Copy link

RastoHu commented Jul 29, 2025

@JanCaha @tomasMizera
I tried to send diagnostic log to localhost and got this error in plugin:
image

ee server
plugin: Mergin b103511

@MarcelGeo
Copy link
Contributor

MarcelGeo commented Jul 30, 2025

Hey guys here. I found the issue here with sending POST request in a client. We are sending here "?" part of url encoded , then server could not find the whole url /v2/diagnostic-logs%3F ... as ? is part of url which is can not be encoded.

in method def post we need to handle query string properly (similar to def get). I think we need better testing of things which are going to py client / plugin by development.

@tomasMizera tomasMizera deleted the send-logs branch September 1, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send diagnostics log to host

6 participants