Skip to content

Prevent zombie Kafka source on low watermark failures #36678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickwwbutler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent zombie Kafka source on low watermark failures #36678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage/src/source/kafka.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ fn render_reader<'scope>(
adjusting your retention policies to prevent this.",
);

let update = HealthStatusUpdate::halting(
let update = HealthStatusUpdate::stalled(
err_str.clone(),
None,
);
Expand Down
8 changes: 8 additions & 0 deletions test/kafka-low-watermark/mzcompose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ def workflow_low_watermark(c: Composition) -> None:
> COMMIT
{select_cmd} SELECT count(*) FROM lwm_{suffix}_tbl
{expected}
$ skip-if
SELECT {"true" if not start_offset_clause else "false"}
# Sleep for 20s to make sure that the source has not restarted (would happen after 5s)
$ sleep-is-probably-flaky-i-have-justified-my-need-with-a-comment duration=20s
{select_cmd} SELECT count(*) FROM lwm_{suffix}_tbl
{expected}
> SELECT count(*) FROM mz_internal.mz_source_status_history hx JOIN mz_catalog.mz_sources s ON hx.source_id = s.id WHERE s.name = 'lwm_{suffix}' AND hx.status = 'starting'
1
""")
print(f"PASSED: {suffix} START OFFSET with low watermark > 0")

Expand Down
Loading