Prevent zombie Kafka source on low watermark failures#36678
Open
patrickwwbutler wants to merge 1 commit into
Open
Prevent zombie Kafka source on low watermark failures#36678patrickwwbutler wants to merge 1 commit into
patrickwwbutler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw an issue where a source failed because the kafka low watermarks were beyond the
resume_upperfor that source, indicating there was data compacted away that we would never get back. However, because the source emitted an error at the timestamp of the snapshot, and then exited, implicitly dropping its capabilities, the remap operator believed that all messages up until the input upper (high watermarks of the kafka partitions) had been completed, and advanced theresume_uppersto the high watermarks. This is normal procedure when emitting definite errors that indicate the source is irreparably broken.However, at this point the kafka replication operator emitted a
HealthStatusUpdatewithhalting = true. This meant that the healthcheck operator would then issue a suspend and restart command to the storage controller. When restarting, because the resume uppers had advanced, the source was able to continue reading from the previous frontier, and the status appeared healthy until querying the source table, when you would get the low watermark error.Instead, we should emit a
HealthStatusUpdate::stalledwhich will tell the healthcheck operator not to issue a restart command, and the source will stay visibly stalled rather than appear healthy.