134 Enhance ReadMe with documentation on parser options #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoledow
changed the title
3 tasks
chawes13
reviewed
Jan 5, 2024
Contributor
chawes13
left a comment
chawes13
left a comment
There was a problem hiding this comment.
LGTM! Can you add bump the version by a patch?
Contributor
Author
Done! |
chawes13
approved these changes
Jan 5, 2024
chawes13
deleted the
134-enhance-readme-with-documentation-on-parser-options-for-default-parsers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items Addressed
Addresses issue #134 by adding a table to the ReadMe that outlines the options parsers currently accept.
Note that #132 adds an option to the
BooleanParser. Depending on the order that this PR and #132 are merged, one or the other will need to update the table with the new option.Review Questions
Author Checklist
version.rbfollowing versioning guidelines