Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

WikiTest.testEmbeddedVideoInWiki triggers a CSP warning. Now that frame-src is modifiable, the test should configure it to allow youtube embedding without triggering a warning.

The Table component is an absolute mess. Taking a small step forward by making it unnecessary to always specify which row contains the column headers. The row defaults to 1 and the dumbster email table sets it to 2. Tables with an actual thead element should set it to 0.
Note: This does not unify the methods that fetch column headers (getTableHeader* looks in thead vs getColumnHeaders which looks in tbody)

Related Pull Requests

Changes

  • Test component for AdminController.ExternalSourceAction
  • Update WikiTest.testEmbeddedVideoInWiki to customize frame-src CSP directive
  • Update Table component to not pass header row index between methods

@labkey-tchad labkey-tchad requested review from a team and labkey-chrisj and removed request for a team March 4, 2025 00:57
@labkey-tchad labkey-tchad merged commit b22cd8c into release25.3-SNAPSHOT Mar 4, 2025
4 checks passed
@labkey-tchad labkey-tchad deleted the 25.3_fb_frameSrcUpdate branch March 4, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants