Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

After my last change, EmailRecordTable.getColumnDataAsText wasn't accounting for the extra, hidden row at the bottom of the table.

org.openqa.selenium.NoSuchElementException: Unable to locate element: ./tbody/tr[8]/td[4]
  [...]
  at app//org.labkey.test.components.html.Table._getDataAsElement(Table.java:207)
  at app//org.labkey.test.components.html.Table.getDataAsElement(Table.java:212)
  at app//org.labkey.test.components.html.Table.getColumnAsElement(Table.java:250)
  at app//org.labkey.test.components.html.Table.getColumnAsText(Table.java:217)
  at app//org.labkey.test.components.html.Table.getColumnAsText(Table.java:233)
  at app//org.labkey.test.components.dumbster.EmailRecordTable.getColumnDataAsText(EmailRecordTable.java:234)
  at app//org.labkey.test.tests.biologics.BiologicsWorkflowIntegrationTest.checkForEmailNotification(BiologicsWorkflowIntegrationTest.java:1389)
  at app//org.labkey.test.tests.biologics.BiologicsWorkflowIntegrationTest.checkForEmailNotification(BiologicsWorkflowIntegrationTest.java:1383)
  at app//org.labkey.test.tests.biologics.BiologicsWorkflowIntegrationTest.testJobTaskCommentsAreSearchIndexed(BiologicsWorkflowIntegrationTest.java:196)

This change fixes EmailRecordTable, largely by cleaning up the server-side component. There was a bunch of cruft that was, long ago, intended to make it compatible with the DataRegionTable test helper at the time.
This also cleans up a bunch of IDE warnings in Dumbster classes.

Related Pull Requests

Changes

  • Fix EmailRecordTable row indexing
  • Clean up dumbster classes and emailWebPart

Clean up dumbster classes and emailWebPart
@labkey-tchad labkey-tchad requested review from a team and labkey-sweta and removed request for a team March 5, 2025 22:18
@labkey-tchad labkey-tchad merged commit 142294b into release25.3-SNAPSHOT Mar 7, 2025
3 checks passed
@labkey-tchad labkey-tchad deleted the 25.3_fb_updateDumbster branch March 7, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants