Add restrictions on names of domains - automated tests #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2024
labkey-susanh
approved these changes
Dec 11, 2024
| ReactAssayDesignerPage assayDesignerPage = startCreateGpatAssay(trialData, invalidAssayName); | ||
| List<String> errors = assayDesignerPage.clickSaveExpectingErrors(); | ||
| assayDesignerPage.clickCancel(); | ||
| Assert.assertTrue("Error msg not as expected during assay creation", errors.contains("Invalid Assay Design name. Domain name must start with a letter or a number character.")); |
Contributor
There was a problem hiding this comment.
Constant for the error message?
|
|
||
| public static String randomInvalidDomainName(int size) | ||
| { | ||
| return randomString(size, null, ILLEGAL_DOMAIN_NAME_CHARSET); |
Contributor
There was a problem hiding this comment.
Might be better (slightly more realistic) if this consisted of some number of illegal characters along with some legal characters. But perhaps the usages of this method already accomplish that.
| String prefix = randomString(1, null, ALPHANUMERIC_STRING); // domain needs to start with alphanumeric char | ||
| final String charset = ALPHANUMERIC_STRING + DOMAIN_SPECIAL_STRING; | ||
| domainName = prefix + randomString(size - 1, null, charset); | ||
| domainName = domainName.trim(); |
Contributor
There was a problem hiding this comment.
How would the name have any spaces to be trimmed?
Contributor
Author
There was a problem hiding this comment.
They might have trailing space due to DOMAIN_SPECIAL_STRING contains whitespace
| domainName = prefix + randomString(size - 1, null, charset); | ||
| domainName = domainName.trim(); | ||
| } | ||
| while (domainName.length() < size || Pattern.matches("(.*\\s--[^ ].*)|(.*\\s-[^- ].*)", domainName)); // domain name must not contain space followed by dash. (command like) |
Contributor
There was a problem hiding this comment.
Would be good to reference the issue number here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes