Make more Locators work with tricky characters #2409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XingY
approved these changes
Apr 11, 2025
labkey-danield
approved these changes
Apr 11, 2025
| * "The normalize-space function strips leading and trailing white-space from a string, replaces sequences of | ||
| * whitespace characters by a single space, and returns the resulting string." | ||
| */ | ||
| private static String ns(String value) |
Contributor
There was a problem hiding this comment.
I would suggest a better, more descriptive method name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Wider use of tricky characters and string has revealed some defects in how we construct Locators.
We use XPath's
normalize-space()method for most text matching but we don't normalize whitespace in the text we are comparing to. We need to perform normalization to both sides of comparisons we perform.We have some Locators that do case-insensitive text matching. The current implementation only works for
A-Z; an XPath translate statement that simulates a toLowerCase sort of operation (translate(normalize-space(), 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz')). We know the String the Locator will be comparing to, so we can construct a translate statement that does atoLowerCasefor just the characters we care about matching, including ones with diacritics (e.g.Ä->ä).Related Pull Requests
Changes