Skip to content

Include websocket "ws:" for reactjs.hot.reload in allowed connections for dev mode #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cnathe wants to merge 1 commit into from
Closed

Include websocket "ws:" for reactjs.hot.reload in allowed connections for dev mode #6343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/org/labkey/filters/ContentSecurityPolicyFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public String getHeaderName()
{
// ReactJS hot reload uses localhost port 3001. If in dev mode, allow browser to access that port.
if (AppProps.getInstance().isDevMode())
registerAllowedConnectionSource("reactjs.hot.reload", "localhost:3001");
registerAllowedConnectionSource("reactjs.hot.reload", "localhost:3001 ws:");
Copy link
Contributor

@labkey-nicka labkey-nicka Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR can be closed in favor of #6345 and we make the same change there.

Copy link
Contributor Author

@cnathe cnathe Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was waiting for the other one to be merged. Closing this now.

}

@Override
Expand Down