Include websocket "ws:" for reactjs.hot.reload in allowed connections for dev mode #6343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ReactJS hot reload uses localhost port 3001. If in dev mode, allow browser to access that port. | ||
| if (AppProps.getInstance().isDevMode()) | ||
| registerAllowedConnectionSource("reactjs.hot.reload", "localhost:3001"); | ||
| registerAllowedConnectionSource("reactjs.hot.reload", "localhost:3001 ws:"); |
Contributor
There was a problem hiding this comment.
I think this PR can be closed in favor of #6345 and we make the same change there.
Contributor
Author
There was a problem hiding this comment.
Yes, I was waiting for the other one to be merged. Closing this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The related PR added localhost to the allowed connections in dev mode to support the client side application dev for hot module reloading. We need to also include websocket "ws:" in that connect-src.
Related Pull Requests
Changes