Convert File usages to use FileLike or the comparable class #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-matthewb
approved these changes
Mar 22, 2025
Contributor
labkey-matthewb
left a comment
labkey-matthewb
left a comment
There was a problem hiding this comment.
I don't know if there is value is updating this admin action (beyond maybe a comment?). The interesting related part of this would be updating FileSettings.getWorkingDirectory()
labkey-klum
approved these changes
Mar 24, 2025
Sigmonia
force-pushed
the
fb_fileControl
branch
from
eec2c8e to
fec9631
Compare
Sigmonia
force-pushed
the
fb_fileControl
branch
from
11207b2 to
143da8a
Compare
Fix lint in FlowCompensationMatrix
labkey-klum
reviewed
Apr 17, 2025
labkey-klum
approved these changes
Apr 17, 2025
Sigmonia
force-pushed
the
fb_fileControl
branch
from
ae7a186 to
58ff7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/kanban/issues/556
Related Pull Requests
Changes