fix: raw_data_stream uses wrong is_ros_subscriber flag#272
Open
ExpectedArgument wants to merge 1 commit intoKumarRobotics:ros2from
Open
fix: raw_data_stream uses wrong is_ros_subscriber flag#272ExpectedArgument wants to merge 1 commit intoKumarRobotics:ros2from
ExpectedArgument wants to merge 1 commit intoKumarRobotics:ros2from
Conversation
When raw_data_stream.enable is true, RawDataStreamPa is constructed with is_ros_subscriber=true, which puts it in subscriber mode. In subscriber mode: - getRosParams() reads 'dir' instead of 'raw_data_stream.dir' - isEnabled() only returns !file_dir_.empty(), ignoring 'publish' flag - setRawDataCallback() is never called → no data flows Fix: pass false as is_ros_subscriber since the GPS node is a producer, not a subscriber of the raw data stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When raw_data_stream.enable is true, RawDataStreamPa is constructed with is_ros_subscriber=true, which puts it in subscriber mode. In subscriber mode:
Fix: pass false as is_ros_subscriber since the GPS node is a producer, not a subscriber of the raw data stream.